-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
rtags: 2.8-p1 -> 2.10 #26280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rtags: 2.8-p1 -> 2.10 #26280
Conversation
I don't understand the Travis CI failure. It built successfully in two configurations, but a third ends up with an unexpected hash. |
the first build only check for evaluation errors. The last two check builds on darwin and linux. |
I get the same error as travis:
I am also on Linux. |
Thank you @Mic92! Can you think of a reason why the sha256 would be different between darwin and Linux? Doing a |
Maybe |
nix-prefetch-git is also consistent on my system: nix-prefetch-git --fetch-submodules https://github.com/andersbakken/rtags.git refs/tags/v2.10
{
"url": "https://github.com/andersbakken/rtags.git",
"rev": "3b3ace901f53827daef81d4c13658ec4feb318b4",
"date": "2017-05-26T14:04:03-07:00",
"sha256": "1swcz4p5v6zqzqrxdbxbcvy009k509s4ni8qqg1wyp537qcibwdb",
"fetchSubmodules": true
} |
I investigated a bit earlier today with some suggestions from IRC, and the most suspicious diff I could find between Linux and Darwin is a file with UTF8 characters in its name and contents. When I dumped file listings to a file on each system and opened in emacs, ediff highlighted that file name as a difference. Possibly a red herring, but it's all I came up with. |
Probably HFS plus does unicode normalisation, which is not the case for other filesystems commonly found on Linux. |
The quick fix would be to just have checksums per platform at the moment, if this is really the root cause. |
Yep, it's the filesystem. I have a machine that doesn't use HFS+ for the store and I get the same hash as linux there. |
With #26358 and this I get the same hash everywhere. - sha256 = "0z32yncn3x1pm2l6r349kfwi6mi83vll820kka87agcla64pl1f2";
+ sha256 = "0rv5hz4cfc1adpxvp4j4227nfc0p0yrjdc6l9i32jj11p69a5401";
+ postFetch = ''
+ rm $out/src/rct/tests/testfile_*.txt
+ ''; |
HFS+ will hopefully be deprecated soon. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)