qtile: Fix using qtile together with desktop #26277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funny bug, which prevent qtile to co-exists with desktop manager (or program pretending to be DE)
Mic92
reviewed
May 31, 2017
| @@ -15,7 +15,7 @@ in | |||
| services.xserver.windowManager.session = [{ | |||
| name = "qtile"; | |||
| start = '' | |||
| ${pkgs.qtile}/bin/qtile | |||
| ${pkgs.qtile}/bin/qtile & | |||
There was a problem hiding this comment.
Can you add more context, how the bug becomes visible?
|
On Wed, May 31, 2017 at 04:36:37PM -0700, Jörg Thalheim wrote:
> @@ -15,7 +15,7 @@ in
services.xserver.windowManager.session = [{
name = "qtile";
start = ''
- ${pkgs.qtile}/bin/qtile
+ ${pkgs.qtile}/bin/qtile &
Can you add more context, how the bug becomes visible?
All WMs/Desktops in NixOS implemented as:
'''
start = ''
${pkg.wm}/bin/command &
waitPID=$!
'';
'''
These statements issued for WM first, then for DE second.
Then it finish with ``wait $waitPID`` (in generated xsession).
So when we have ``qtile`` without ``&`` -- xsession blocks, till qtile
termination. Then desktop binary executed, when wm already
terminated, and X server gone.
|
kamilchm
approved these changes
Jun 1, 2017
|
Works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Funny bug, which prevent qtile to co-exists with desktop manager
(or program pretending to be DE)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)