MatchData: improve error message when refer no matched existed capture group #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e group For example, `"foo".match(/(?<g1>x)?foo/)["g1"]` raises an exception with message `"Match group 'g1' does not exist"`, bu group `"g1"` exists surely and it isn't matched on this matching. I think we can improve such an error message.
RX14
requested changes
Jun 12, 2017
src/regex/match_data.cr
Outdated
| if ret < 0 | ||
| raise KeyError.new("Capture group named '#{group_name}' does not exist") | ||
| else | ||
| raise KeyError.new("Capture group named '#{group_name}' is not matched") |
There was a problem hiding this comment.
"was not matched" sounds better
src/regex/match_data.cr
Outdated
| @@ -315,5 +320,9 @@ class Regex | |||
| private def raise_invalid_group_index(index) | |||
| raise IndexError.new("Invalid capture group index: #{index}") | |||
| end | |||
|
|
|||
| private def raise_not_matched_group_index(index) | |||
| raise IndexError.new("Not matched capture group index: #{index}") | |||
There was a problem hiding this comment.
Maybe "Capture group index was not matched: #{index}"?
|
@makenowjust I agree with @RX14 , let's use:
|
|
@asterite Ok. I'll fix it. |
|
@makenowjust I think it's fine like that |
|
@asterite Thank you ❤️ |
RX14
requested changes
Jun 13, 2017
src/regex/match_data.cr
Outdated
| raise KeyError.new("Capture group named '#{group_name}' is not matched") | ||
| end | ||
| status = ret < 0 ? "does not exist" : "was not matched" | ||
| raise KeyError.new("Capture group '#{group_name}' #{status}") |
There was a problem hiding this comment.
I think having 2 if branches here is much cleaner. Removing duplication isn't always good.
There was a problem hiding this comment.
I use 80 column terminal window always, so this line is hard to read if if nested. It's only reason.
There was a problem hiding this comment.
But it's little problem, so I fixed it.
makenowjust
force-pushed
the
fix/regex-match-data/improve-error-message
branch
from
c758745
to
de1c217
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
"foo".match(/(?<g1>x)?foo/).not_nil!["g1"]raises an exception with message"Match group 'g1' does not exist", but group"g1"exists surely and it isn't matched on this matching. I think we can improve such an error message.