Don't run pre-build-hook if we don't have a derivation

edolstra · edolstra · commit 7f5b750b401e · 2017-06-12T16:07:34.000+02:00
This fixes a build failure on OS X when using Hydra or Nix 1.12's
build-remote (since they don't copy the derivation to the build
machine).
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
@@ -1950,7 +1950,7 @@ void DerivationGoal::startBuilder()
                 }
     }
 
-    if (settings.preBuildHook != "") {
+    if (useChroot && settings.preBuildHook != "" && dynamic_cast<Derivation *>(drv.get())) {
         printMsg(lvlChatty, format("executing pre-build hook ‘%1%’")
             % settings.preBuildHook);
         auto args = useChroot ? Strings({drvPath, chrootRootDir}) :

Original file line number	Diff line number	Diff line change
`@@ -1950,7 +1950,7 @@ void DerivationGoal::startBuilder()`
`1950`	`1950`	`}`
`1951`	`1951`	`}`
`1952`	`1952`
`1953`		`- if (settings.preBuildHook != "") {`
	`1953`	`+ if (useChroot && settings.preBuildHook != "" && dynamic_cast<Derivation *>(drv.get())) {`
`1954`	`1954`	`printMsg(lvlChatty, format("executing pre-build hook ‘%1%’")`
`1955`	`1955`	`% settings.preBuildHook);`
`1956`	`1956`	`auto args = useChroot ? Strings({drvPath, chrootRootDir}) :`