Fixes #4662. LoadError with compiled multi-byte constant.

The original code was using String.length() then saving getBytes() but length() reports characters and not bytes so multi-byte strings were not getting saved with the correct length. More commentary in the issue since even with this fix we are still broken in a known but more fundamental way (and we have since the beginning of time).
jruby · Jun 12, 2017 · f86604a · f86604a
1 parent d56b9bb
commit f86604a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/src/main/java/org/jruby/ir/persistence/IRWriterStream.java b/core/src/main/java/org/jruby/ir/persistence/IRWriterStream.java
@@ -150,8 +150,9 @@ public void encode(String value) {
         if (value == null) {
             encode(NULL_STRING);
         } else {
-            encode(value.length());
-            buf.put(value.getBytes());
+            byte[] bytes = value.getBytes();
+            encode(bytes.length);
+            buf.put(bytes);
         }
     }