[WIP] images metadata #2837
Closed
[WIP] images metadata #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, once newstyle mode is detected, the metadata are read from the initial file itself, which is wrong.
It is now possible to add a .meta file associated to any image file in galleries. The contained metadata are made available to the gallery.tmpl.
If people don't want to show image metadata, then don't put meta files there.
As suggested by CONTRIBUTING.rst.
Needed since we can have textual information associated with images. Cf. https://blog.mozilla.org/webdev/2009/02/20/cross-browser-inline-block/
added 2 commits
June 23, 2017 12:10
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code by @guyou I am taking over for polish and stuff, all merit goes to him.