Skip to content

fix electrum dependencies #26251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 31, 2017
Merged

fix electrum dependencies #26251

merged 7 commits into from
May 31, 2017
+183 −86

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented May 30, 2017 •
edited
Loading

Motivation for this change

See #26249

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using
  • Tested execution of all binary files
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mention-bot
Copy link

@rnhmjoj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh
Copy link
Member

FRidh commented May 30, 2017

Could you move each of these expressions to new files as described in the header of python-packages.nix. That will make future updating easier as well.

@FRidh FRidh added 6.topic: python 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version labels May 30, 2017
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented May 30, 2017

Ah, sorry I missed it.

rnhmjoj added 7 commits May 30, 2017 21:36
@rnhmjoj
pythonPackages.hidapi: 0.7.99.post15 -> 0.7.99.post20

Verified

This commit was signed with the committer’s verified signature. The key has expired.
LnL7 Daiderd Jordan
GPG key ID: D02435D05B810C96
Expired
Verified
Learn about vigilant mode
91a56e1
@rnhmjoj
pythonPackages.libagent: init at 0.9.1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
LnL7 Daiderd Jordan
GPG key ID: D02435D05B810C96
Expired
Verified
Learn about vigilant mode
26fbe26
@rnhmjoj
pythonPackages.trezor_agent: 0.7.0 -> 0.9.1

Verified

This commit was signed with the committer’s verified signature. The key has expired.
LnL7 Daiderd Jordan
GPG key ID: D02435D05B810C96
Expired
Verified
Learn about vigilant mode
fe98f01
@rnhmjoj
pythonPackages.keepkey: fix impossible constraint

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b2a8b7d
@rnhmjoj
pythonPackages.ecpy: init at 0.8.1
0db8285
@rnhmjoj
pythonPackages.ledgerblue: init at 0.1.13
3f9b6dd
@rnhmjoj
move libraries to pkgs/development/python-modules
e73f995
@FRidh FRidh merged commit d4aecb3 into NixOS:master May 31, 2017
@FRidh FRidh mentioned this pull request May 31, 2017
Merged
@FRidh
Copy link
Member

FRidh commented May 31, 2017

@rnhmjoj I just noticed there were evaluation errors so I reverted it. Furthermore, the expressions are supposed to be in pkgs/development/python-modules/<pname>/default.nix. Unfortunately there's a lot that aren't.

@rnhmjoj rnhmjoj mentioned this pull request May 31, 2017
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @mention-bot @FRidh