Skip to content

i3blocks: add optional dependencies for scripts #26254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2017

Conversation

boomshroom
Copy link
Contributor

@boomshroom boomshroom commented May 30, 2017

Motivation for this change

Many of the builtin scripts provided with i3blocks depend on packages not available by default.
This change makes sure that the various scripts can access their own dependencies.

Additionally, an parameter scripts has been added to select which scripts to provide the
dependencies of. By default, the dependencies of all defaults will be installed.
To change this behavior override scripts with a list of string corresponding to the desired packages.

TODO:

  • Provide better interface for selecting scripts.
  • Provide better default. (currently: all)
  • Don't install undesired scripts.
  • Select FreeBSD tools when on FreeBSD
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
mcollina Matteo Collina
@FRidh
Copy link
Member

FRidh commented Jun 6, 2017

cc maintainer @carlsverre

@Mic92 Mic92 merged commit f56d837 into NixOS:master Jun 10, 2017
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants