Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge yet. This is a RFC with a known bug that I'm in the process of fixing.EDIT: the PR is finished now and the test passes successfully.
This PR is based on the elasticsearch-5.4 upgrade (#25857). It contributes the following:
elasticsearch5
courtesy of @apescharkibana5
andlogstash5
elk5Version
)Currentlylogstash5
has issues because I see the following when running the testsuite:It would be nice if somebody could help me debug this because I'm not a Ruby developer. Pinging maintainers of logstash: @offlinehacker @wjlroe