XML: allow adding/changing an attribute's value. Fixes #4562

crystal-lang · Jun 13, 2017 · 526837e · 526837e
1 parent 68b1e62
commit 526837e
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 1 deletion.
diff --git a/spec/std/xml/xml_spec.cr b/spec/std/xml/xml_spec.cr
@@ -315,4 +315,25 @@ describe XML do
       str.should eq("&lt; &amp; &gt;")
     end
   end
+
+  it "sets an attribute" do
+    doc = XML.parse(%{<foo />})
+    root = doc.root.not_nil!
+
+    root["bar"] = "baz"
+    root["bar"].should eq("baz")
+    root.to_s.should eq(%{<foo bar="baz"/>})
+  end
+
+  it "changes an attribute" do
+    doc = XML.parse(%{<foo bar="baz"></foo>})
+    root = doc.root.not_nil!
+
+    root["bar"] = "baz"
+    root["bar"].should eq("baz")
+    root.to_s.should eq(%{<foo bar="baz"/>})
+
+    root["bar"] = 1
+    root["bar"].should eq("1")
+  end
 end
diff --git a/src/xml/attributes.cr b/src/xml/attributes.cr
@@ -37,6 +37,11 @@ struct XML::Attributes
     find { |node| node.name == name }
   end
 
+  def []=(name : String, value)
+    LibXML.xmlSetProp(@node, name, value.to_s)
+    value
+  end
+
   def each : Nil
     return unless @node.element?
 

diff --git a/src/xml/libxml2.cr b/src/xml/libxml2.cr
@@ -292,6 +292,8 @@ lib LibXML
   fun xmlSetGenericErrorFunc(ctx : Void*, f : GenericErrorFunc)
 
   fun xmlGetNsList(doc : Doc*, node : Node*) : NS**
+
+  fun xmlSetProp(node : Node*, name : UInt8*, value : UInt8*) : Attr*
 end
 
 LibXML.xmlGcMemSetup(

diff --git a/src/xml/node.cr b/src/xml/node.cr
@@ -34,7 +34,7 @@ struct XML::Node
 
   # Sets *attribute* of this node to *value*.
   # Raises `XML::Error` if this node does not support attributes.
-  def []=(name : String, value : String)
+  def []=(name : String, value)
     raise XML::Error.new("Can't set attribute of #{type}", 0) unless element?
     attributes[name] = value
   end