Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image captions (Part of #2777) #2829

Merged
merged 2 commits into from Jun 10, 2017
Merged

image captions (Part of #2777) #2829

merged 2 commits into from Jun 10, 2017

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jun 7, 2017

  • Use alt attribute for lightbox captions
  • Set alt attribute to image title in base theme galleries.

@ralsina
Copy link
Member Author

ralsina commented Jun 7, 2017

This seems to fail on windows because of some missing symlinks? Any ideas @Kwpolska ?

@Kwpolska
Copy link
Member

Kwpolska commented Jun 8, 2017

Fixed (I deleted some useless unminified files and hadn’t updated the symlinked list when you branched out)

Kwpolska
Kwpolska approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralsina ralsina merged commit ede1b13 into master Jun 10, 2017
@ralsina ralsina deleted the baguette-captions branch June 10, 2017 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kwpolska Kwpolska Kwpolska approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska