New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an is_tuple_like trait for sequenceable type detection #2687
Conversation
hpx/traits/is_tuple_like.hpp
Outdated
util::tuple_size<T>::value | ||
)>::type> : std::true_type { }; | ||
}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to adapt your style of formatting to the rest of HPX. I'll send you a .clang-format file which you can use as a starting point.
Please add the new #include here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/include/traits.hpp |
I fixed the code formatting and added the trait to the include compilation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@Naios: the current build failures are caused by a bogus commit you picked up by merging from master. Please merge again, this should resolve the issue. |
@hkaiser I rebased the PR accordingly, but the CI is still failing |
Requires #2685, otherwise the unit test won't pass