Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: enable static libraries on Darwin #26456

Closed
wants to merge 1 commit into from
Closed

boost: enable static libraries on Darwin #26456

wants to merge 1 commit into from

Conversation

mbrock
Copy link
Contributor

@mbrock mbrock commented Jun 7, 2017

Motivation for this change

This seems to be necessary for CMake/Boost projects to build on Darwin.

My test case was solc, which currently does not build on Darwin.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This seems to be necessary for CMake/Boost projects to build on Darwin.

My test case was `solc`, which currently does not build on Darwin.
@edolstra
Copy link
Member

edolstra commented Jun 7, 2017

Maybe solc should be fixed then?

@mbrock
Copy link
Contributor Author

mbrock commented Jun 8, 2017

@edolstra I'll investigate a bit more tomorrow. Someone told me that they tried multiple Nixpkgs derivations on Darwin that use CMake and Boost and all failed to compile for this reason, but I'm not sure what's going on.

@mbrock
Copy link
Contributor Author

mbrock commented Jul 17, 2017

Changed solc instead of boost in another merged pull request.

@mbrock mbrock closed this Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants