Parser: correct accept_with_maybe_begin_end to wrap control expression #4489

makenowjust · 2017-05-31T06:46:56Z

#4488's example:

record Foo do
  def foo
    return true ? 1 : 2
  end
end

is expanded to:

struct Foo
  # ...

  def foo
    return if true
      1
    else
      2
    end
  end
end

So it causes parse error.

This PR fixes it by wrapping control expression with begin and end.

struct Foo
  # ...

  def foo
    return begin
      if true
        1
      else
        2
      end
    end
  end
end

asterite

Great! I didn't have time to debug the problem but the fix looks correct.

spalladino · 2017-05-31T12:20:31Z

Whoa, that was fast! Thanks a lot!!

sdogruyol · 2017-05-31T12:25:01Z

As a Japanese himself i declare @makenowjustさん "Crystal パッチモンスター" 🎉 　

Parser: correct accept_with_maybe_begin_end to wrap if/unless/while/u…

3c3edda

…ntil Fixed crystal-lang#4488

asterite approved these changes May 31, 2017

View reviewed changes

spalladino merged commit 8f1931c into crystal-lang:master May 31, 2017

spalladino added this to the Next milestone May 31, 2017

makenowjust deleted the fix/crystal/to-s-no-postfix-control branch August 6, 2017 13:44

Provide feedback