Fix 2798 #2799
Merged
Fix 2798 #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
May 25, 2017
| content_format = get_default_compiler( | ||
| is_post, | ||
| self.site.config['COMPILERS'], | ||
| self.site.config['post_pages']) | ||
|
|
||
| if content_format not in compiler_names: | ||
| elif content_format not in compiler_names: |
There was a problem hiding this comment.
Perhaps that if was there for a reason? (I can’t see it though.)
There was a problem hiding this comment.
I checked, this seems to work just as well :)
| if extension in extensions: | ||
| content_format = compiler | ||
|
|
||
| elif not content_format and import_file: |
There was a problem hiding this comment.
Perhaps we could merge that and the first if into one?
There was a problem hiding this comment.
Perhaps, but it saves 3 lines of code at the cost of a non-stupid condition. I like stupid conditions.
Kwpolska
approved these changes
May 25, 2017
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess content format from path or imported file on
nikola new_postFixes #2798