Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch20170604 #329

Merged
merged 6 commits into from Jun 4, 2017
Merged

Patch20170604 #329

merged 6 commits into from Jun 4, 2017

Conversation

kazuyaujihara
Copy link
Contributor

Patches for minor issues except NoSuchElementException issue.

@johnmay johnmay merged commit 67239ce into cdk:master Jun 4, 2017
@johnmay
Copy link
Member

johnmay commented Jun 4, 2017

All good

IAtom startQAtom = bond.getBegin();
IAtom middleQAtom = bond.getEnd();
IAtom startQAtom = bond.getAtom(0);
IAtom middleQAtom = bond.getAtom(1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnmay, just for my understanding... what's wrong getBegin/getEnd? That's what you recently changed, not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because bond.getAtom(2) is called after so it's slightly neater. I don't mind using the 0, 1 if there is a 2 (ofcourse I'd remove all bonds with more than two atoms if I could)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, duh... sorry, was distracted too much by the changes that I did not notice the getAtom(2)... not now, not when I reviewed your getBegin/getEnd patch...

@kazuyaujihara kazuyaujihara deleted the patch20170604 branch December 6, 2017 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants