Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: 1.12.1 -> 1.12.2 #26364

Merged
merged 1 commit into from Jun 4, 2017
Merged

vscode: 1.12.1 -> 1.12.2 #26364

merged 1 commit into from Jun 4, 2017

Conversation

winniequinn
Copy link
Contributor

Motivation for this change

Translation additions and various fixes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@winniequinn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benley, @jgillich and @uralbash to be potential reviewers.

@gebner gebner merged commit ec418ba into NixOS:master Jun 4, 2017
@winniequinn winniequinn deleted the vscode-1.12.2 branch June 10, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants