Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 2.5.2 -> 2.6.2 #26366

Merged
merged 1 commit into from Jun 4, 2017
Merged

slack: 2.5.2 -> 2.6.2 #26366

merged 1 commit into from Jun 4, 2017

Conversation

winniequinn
Copy link
Contributor

I added libxcb as a dependency. Without it, 2.6.2 crashes on launch:

$ slack
slack: error while loading shared libraries: libxcb.so.1: cannot open
shared object file: No such file or directory
Motivation for this change

Various fixes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@winniequinn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @greyson, @fooblahblah and @abbradar to be potential reviewers.

@Mic92 Mic92 merged commit c323869 into NixOS:master Jun 4, 2017
@winniequinn winniequinn deleted the slack-2.6.2 branch June 10, 2017 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@winniequinn @mention-bot @Mic92