Allowing to register filters. #2819
Conversation
| # Ignore objects whose name starts with an underscore, or which are not callable | ||
| if filter_name.startswith('_'): | ||
| continue | ||
| if not hasattr(filter_definition, '__call__'): |
There was a problem hiding this comment.
if not callable(filter_definition):
| # OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE | ||
| # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| """Registers all default filters.""" |
There was a problem hiding this comment.
It doesn’t need to be a plugin. Put this in nikola.py.
There was a problem hiding this comment.
Wasn't the idea in Nikola to move more stuff into plugins to make everything more modular? If this wouldn't need to be backwards compatible, I'd move the filter definitions into the plugin as well.
But if you prefer that, I can remove the plugin.
There was a problem hiding this comment.
Yeah, modularity is good, but we don’t need modularity for something there is no real need/reason for end users to disable. Post scanners are plugins, because you can have other ways of scanning posts. Setting up globals doesn’t need to be a plugin, because everyone needs those. Plus, reading (edit: more .plugin and .py files) can be costly (on Raspberry Pi SD cards, for example)
There was a problem hiding this comment.
Ok, changed that.
nikola/nikola.py
Outdated
| @@ -414,6 +414,7 @@ def __init__(self, **config): | |||
| self._template_system = None | |||
| self._THEMES = None | |||
| self._MESSAGES = None | |||
| self._filters = {} | |||
nikola/nikola.py
Outdated
| if filter is not None: | ||
| actions[i] = filter | ||
|
|
||
| # Configure filters |
nikola/nikola.py
Outdated
| one argument (the filename). | ||
| """ | ||
| prev_filter = self._filters.get(filter_name) | ||
| if prev_filter is not None: |
There was a problem hiding this comment.
if filter_name in self.filters:
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
Thanks for merging! |
Pull Request Checklist
Description
Allows config plugins to register filters. Registers default filters with the names
filters.<name>.This implements the first part of the filters discussion in #2475 and is the first step of removing Python code from
conf.py. This PR should not handle the shortcuts which allow to include Python code for filters (and global context) without creating plugins; that's for another PR.