Fix current-stage compiler stats output #4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asterite looks like master is broken. :( |
|
@RX14 Sorry about that, it's fixed now. Could you rebase? :-) And thank you for the fix! |
Before be945b5, --stats output would print the current stage name while it was executing. This is useful for debugging compiler hangs and tracking the progress of the compiler without --progress. After that commit, the progress output would only print after the stage had fully completed, meaning you had to rely on --progress to track compiler progress. This patch fixes this regression by printing the stage name (with no times or memory figures) before the stage starts and resetting the cursor to the beginning of the line. If both --progress and --stats are specified, this pre-stage line isn't printed as it would just be overwritten by --progress output anyway.
RX14
force-pushed
the
bugfix/stats-realtime
branch
from
4ccba25
to
7191faf
Compare
|
@asterite done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before be945b5,
--statsoutput would print the current stage name while it was executing. This is useful for debugging compiler hangs and tracking the progress of the compiler without--progress. After that commit, the progress output would only print after the stage had fully completed, meaning you had to rely on--progressto track compiler progress.This patch fixes this regression by printing the stage name (with no times or memory figures) before the stage starts and resetting the cursor to the beginning of the line. If both
--progressand--statsare specified, this pre-stage line isn't printed as it would just be overwritten by--progressoutput anyway.