Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerbal Atomics Patch #1663

Merged
merged 10 commits into from Jun 25, 2017
Merged

Kerbal Atomics Patch #1663

merged 10 commits into from Jun 25, 2017

Conversation

Temeter
Copy link
Contributor

@Temeter Temeter commented Jun 3, 2017

Patch for Kerbal Atomics, adding Nerva I/Nerva II/BNTR, as well as the plumes.

Only two minor issues remaining:

  1. Engines start off glowing red, before they visually cool off. Might be a bug; seems a bit inconsistent. (emissives)

  2. non-ro engine don't get removed.

Help for those issues would be appreciated.

@SirKeplan
Copy link
Member

Great, nice to add engines from this pack.
couple of things.

i'm not sure about the emissives, my guess would be to try @heatProduction in the ModuleEngines*. Though i see a different bug, they appear cool on the launch pad, but then warm up visually(but only a little)

to remove non RO parts you can use !PART[Part_Name]:FOR[RealismOverhaul] {}

@Temeter
Copy link
Contributor Author

Temeter commented Jun 23, 2017

Thanks. I couldn't find any information about the Nerva 1+2, only about Nerva Alpha/Gamma, including their pictures - seems like the latter two being small scale versions for the space shuttle payload bay.

to remove non RO parts you can use !PART[Part_Name]:FOR[RealismOverhaul] {}

Tried that, also removed the RO version of the engines.

I'll do the rescaling next. Gonna check the @heatproduction again, but otherswise I don't think it's much of an issue.

@PhineasFreak
Copy link
Contributor

@Temeter If it removed the parts then something is off (not with the current patches, the MM passes for them are OK). Did you double check the part names? As i see from the part names, it does not seem very difficult to mess up some of that "encoding".

@Temeter
Copy link
Contributor Author

Temeter commented Jun 24, 2017

@PhineasFreak Still removes RO engines. Basically, the top of my file looks like this for me:

!PART[ntr-sc-25-1]:FOR[RealismOverhaul] {}
!PART[ntr-gc-25-1]:FOR[RealismOverhaul] {}
!PART[ntr-gc-25-2]:FOR[RealismOverhaul] {}
!PART[ntr-sc-125-1]:FOR[RealismOverhaul] {}
!PART[ntr-sc-125-2]:FOR[RealismOverhaul] {}

@part[ntr-sc-25-1]:FOR[RealismOverhaul] etcetcetc

I've copied it almost exactly from another RO mod config, probably I'm doing something wrong?

I think there generally might be something weird going on with Kerbal Atomics. IE, without those entries, all engines stay - except the Stubber (smaller bulky thing I made Nerva 2), which actually gets replaced.

@PhineasFreak
Copy link
Contributor

Hmm, maybe the base part modules are copies of the other parts (that get removed by the RO pass)? I cannot see any other reason for these parts to fail.

@Temeter
Copy link
Contributor Author

Temeter commented Jun 24, 2017

On a more positive note, the correctly scaled Nerva 1 still looks good, despite being over 10 meters high. Nertea makes awesome models! The stock Nerva is actually scaled too small.

Now the Nerva 2, plume adaptions, and we're ready to go.

@Temeter
Copy link
Contributor Author

Temeter commented Jun 24, 2017

Ok, fixed all that nonsense :D

Done now, I've updated the dimensions to mirror the data points, and the plumes look good too. I might switch around models with the new KA 1.3 engines (eel in particular), but that's for the future.

IMO it's ready to be added, if nothing else comes up. Those minor issues aren't too relevant.

Hmm, maybe the base part modules are copies of the other parts (that get removed by the RO pass)? I cannot see any other reason for these parts to fail.

Sorry, I don't really get how that stuff works. Mostly learned by checking stuff out. As said, it's already weird how the Stubber gets replaced just fine, but not the other engines.

@SirKeplan
Copy link
Member

Cool, looks good except the plumes look rather undersized to me, on the NERVAs atleast.
This is most visible when testing them at sea level. consider using a similar plume scale to the stock NERVA.

@Temeter
Copy link
Contributor Author

Temeter commented Jun 25, 2017

Done, increased it to 2.25 and 2.5. I'd almost like to make them bigger, but then the FX starts becoming pixelated. :/

@SirKeplan SirKeplan merged commit efc99a6 into KSP-RO:master Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants