tilix: init at 1.5.8 #26349
tilix: init at 1.5.8 #26349
Conversation
| ''; | ||
|
|
||
|
|
||
| ldLibraryPath = stdenv.lib.makeLibraryPath (gtkd.ldLibraries ++ [ libsecret ]); |
There was a problem hiding this comment.
if you need this temporarily, use a let ... in expression instead
| installFlags = "prefix=$(out)"; | ||
|
|
||
| passthru = { | ||
| ldLibraries = propagatedBuildInputs; |
There was a problem hiding this comment.
why add these to passthru? First of all, propagatedBuildInputs is an attribute that you could use, second of all, why do you even need it? These inputs are propagated, so a derivation depending on this expression will all those to its inputs.
There was a problem hiding this comment.
I initially passed gtkd.propagatedBuildInputs to makeLibraryPath in the tilix package, but it couldn't generate paths from the out output of the dependent packages.
| name = "tilix-${version}"; | ||
| version = "1.5.8"; | ||
|
|
||
| src = fetchurl { |
| substituteInPlace $out/share/applications/com.gexperts.Tilix.desktop \ | ||
| --replace "Exec=tilix" "Exec=$out/bin/tilix" | ||
|
|
||
| gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${ldLibraryPath}") |
There was a problem hiding this comment.
Why set LD_LIBRARY_PATH? What is it that cannot find the libraries?
There was a problem hiding this comment.
It's set because gtkd uses dlopen to load the dependent libraries.
There was a problem hiding this comment.
in such cases we patch the code using absolute paths to the libraries
Motivation for this change
Tilix is a tiling terminal emulator following the Gnome human interface guidelines.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)