apvlv: copy main_menubar.glade to out dir #26368
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application requires the main_menubar.glade alongside the
Startup.pdf. Just making sure all required assets are present 😉.
Currently `apvlv` fails with the `(apvlv:16999): Gtk-ERROR **: failed to add UI: Failed to open file '${store-path}-apvlv-0.1.5/share/doc/apvlv/main_menubar.glade': No such file or directory
zsh: trace trap apvlv` error.
vidbina
added a commit
to vidbina/nixos-configuration
that referenced
this pull request
Jun 4, 2017
|
While using git fetch upstream release-17.03 # upstream git remote points to github.com/NixOS/nixpkgs on my system
git checkout upstream/release-17.03
git cherry-pick -x <commit hash>
git push upstream HEAD:release-17.03 |
|
back ported in f7c081b |
|
wrapGAppsHook was also missing, fixed in 8ddf6f9 Otherwise it crashes when a file dialog is opened. |
|
Thanks for 8ddf6f9. I missed that since I didn't use any dialogs during my test. I'll employ more rigor publiishing subsequent PR's 😉 |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The application relies on main_menubar.glade to generate part of the GTK-based UI.
Currently
apvlvfails with the(apvlv:16999): Gtk-ERROR **: failed to add UI: Failed to open file '${NIX_PREFIX}-apvlv-0.1.5/share/doc/apvlv/main_menubar.glade': No such file or directory zsh: trace trap apvlverror because this file is copied into the output directory for the package.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)TL;DR
Added the apvlv package to my nixos-configuration and ended up with an error message that indicated a missing main_menubar.glade file. After initially writing an override for my own setup, I decide to add the cp command for the required file to the installPhase in the nixpkgs description. Built this against my
nixos-versionto confirm it works, subsequently against release-17.03 9e0a260 (which took forever tonixos-rebuild test) then failed becausegit.efa3635.drvcouldn't be built and finally cherry-picked the commit of interest into master.