Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2816 — use inheritance tree when looking for engine #2818

Merged
merged 1 commit into from Jun 4, 2017
Merged

Fix #2816 — use inheritance tree when looking for engine #2818

merged 1 commit into from Jun 4, 2017

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Jun 4, 2017 •
edited

This fixes #2816. cc @t-animal.

A release would be a good idea, but after #2817 and with more of #2801 done.

@Kwpolska
Fix #2816 — use inheritance tree when looking for theme engine
7120a21 
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.8.7 milestone Jun 4, 2017
@Kwpolska Kwpolska requested a review from ralsina June 4, 2017 09:46
felixfontein
felixfontein approved these changes Jun 4, 2017
View reviewed changes
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ralsina ralsina merged commit 7b355d3 into master Jun 4, 2017
@ralsina ralsina deleted the inherit-engine-file branch June 4, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralsina ralsina ralsina approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
BLOCKER bug
Projects
None yet
Milestone
v7.8.7
Development

Successfully merging this pull request may close these issues.

jinja-themes broken without warning if parent-file exists
3 participants
@Kwpolska @ralsina @felixfontein