aliza: init at 1.29.2 #26352
aliza: init at 1.29.2 #26352
Conversation
| ''; | ||
|
|
||
| meta = { | ||
| homepage = "http://www.aliza-dicom-viewer.com"; |
There was a problem hiding this comment.
Can you also add a license and a description? Do you want to maintain this package?
There was a problem hiding this comment.
I couldn't really make out what may be the license based on the website: http://www.aliza-dicom-viewer.com/info/copyright , should it be free?
As for the other problems, I'm adding those.
There was a problem hiding this comment.
It is licenses.unfreeRedistributable as they only provide binaries.
There was a problem hiding this comment.
Should something be done about it being hosted on google drive?
There was a problem hiding this comment.
Does they keep old releases (is the URL stable)? Apart from that it is not a problem.
There was a problem hiding this comment.
Unfortunately I couldn't find old releases on the website
| --prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath [ qt4 zlib stdenv.cc.cc ]} | ||
|
|
||
| wrapProgram $out/bin/aliza-vtkvol \ | ||
| --prefix LD_LIBRARY_PATH : ${stdenv.lib.makeLibraryPath [ qt4 zlib stdenv.cc.cc libX11 libXt ]} |
There was a problem hiding this comment.
You can use the --set-rpath parameter of patchelf instead of LD_LIBRARY_PATH to set the library path.
There was a problem hiding this comment.
Tried, but it results in the following error message multiple times:
./result/bin/aliza: ./result/bin/aliza: no version information available (required by ./result/bin/aliza)
|
Could you ask upstream to keep old releases. Otherwise the url will likely break in future. It already returns 404. |
|
@Mic92 They've answered my email, unfortunately they won't host older releases, but they allowed me to do so. So I will host the last versions on my Google Drive account adding newer ones as I bump the nixos package, if it's okay with you. |
|
That is ok. Can you do this right away and also add a note, that your are hosting it? There is also archive.org, which you could use. |
|
@Mic92 I've added the note, and at the same time changed the package from deb to rpm-based, as that was recommended upstream. Also, bumped to next version which resulted in more dependencies, so I reformatted the wrapProgram part a bit. |
|
ok, please make sure to never delete this version from your drive. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)