Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchgit: add postFetch argument #26358

Merged
merged 1 commit into from Jun 4, 2017
Merged

fetchgit: add postFetch argument #26358

merged 1 commit into from Jun 4, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 3, 2017

Motivation for this change

Adds the postFetch argument similar to fetchurl.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rbvermaa, @vcunat and @peti to be potential reviewers.

@LnL7 LnL7 mentioned this pull request Jun 3, 2017
Merged
7 tasks
@Mic92 Mic92 merged commit ee22e3d into NixOS:master Jun 4, 2017
@Mic92
Copy link
Member

Mic92 commented Jun 4, 2017

Sounds useful.

@LnL7 LnL7 deleted the fetchgit-postfetch branch June 4, 2017 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: fetch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @mention-bot @Mic92 @lukateras