Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.downcase(Unicode::CaseOptions::Fold) without char ranges #4511

Closed
wants to merge 3 commits into from
Closed

.downcase(Unicode::CaseOptions::Fold) without char ranges #4511

wants to merge 3 commits into from

Conversation

akzhan
Copy link
Contributor

@akzhan akzhan commented Jun 4, 2017 •
edited

The Fold option is required for correct Unicode string comparison using fold case.

It consumes more memory than #4512.

@sdogruyol
Copy link
Member

Thank you @akzhan 💯

@akzhan akzhan changed the title [WIP] String.casefold and Char.casefold instance methods String.casefold and Char.casefold instance methods Jun 4, 2017
@akzhan akzhan changed the title String.casefold and Char.casefold instance methods Stringdowncase(Unicode::CaseOptions::Fold). and Char.casefold instance methods Jun 4, 2017
@akzhan akzhan changed the title Stringdowncase(Unicode::CaseOptions::Fold). and Char.casefold instance methods String.downcase(Unicode::CaseOptions::Fold) and Char.downcase(Unicode::CaseOptions::Fold) Jun 4, 2017
@akzhan
Copy link
Contributor Author

akzhan commented Jun 4, 2017 •
edited

Just for information - trying to extract case fold information using CaseRange:

  • Number of records decreased twice approx. by 600.

@akzhan akzhan mentioned this pull request Jun 4, 2017
Merged
@akzhan akzhan changed the title String.downcase(Unicode::CaseOptions::Fold) and Char.downcase(Unicode::CaseOptions::Fold) .downcase(Unicode::CaseOptions::Fold) without char ranges Jun 4, 2017
@akzhan
Copy link
Contributor Author

akzhan commented Jun 4, 2017

There can be only one.

@akzhan akzhan closed this Jun 4, 2017
@akzhan akzhan deleted the string-and-char-casefold branch June 12, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akzhan @sdogruyol