Skip to content

Commit

Permalink
Support thrust offset (for engines where some models have verniers an…
Browse files Browse the repository at this point in the history
…d others don't). See especially RD-107/8. @PhineasFreak and @SirKeplan you two do the most global configs yes?
  • Loading branch information
NathanKell committed Jun 9, 2017
1 parent 18c7385 commit 8fd1716
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions GameData/RealismOverhaul/Engine_Configs/EngineVariants_Config.cfg
Expand Up @@ -51,6 +51,24 @@
}
}

// ==================================================
// For engines with verniers where we default to
// configuring one way (e.g. has them) but this one
// lacks them, or vice versa.
// ==================================================

@PART[*]:HAS[#thrustOffset[*]]:AFTER[RealismOverhaulEngines]
{
@MODULE[ModuleEngineConfigs]
{
@CONFIG,*
{
@minThrust += #$../../thrustOffset$
@minThrust += #$../../thrustOffset$
}
}
}

// ==================================================
// Deletes origmass if ignoreMass field is found, use
// it to avoid the engine changing the mass of a part.
Expand Down Expand Up @@ -91,5 +109,6 @@
!minActiveEngines = NULL
!useVerniers = NULL
!massOffset = NULL
!thrustOffset = NULL
!ignoreMass = NULL
}

6 comments on commit 8fd1716

@PhineasFreak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't the useVerniers parameter already take care of that?

@NathanKell
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh tarnation, did I miss an addition and duplicate work? What I get for checking out :D

@NathanKell
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have typos anyway. Blergh.

@NathanKell
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, totally a dupe. Removing.

@PhineasFreak
Copy link
Contributor

@PhineasFreak PhineasFreak commented on 8fd1716 Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, something that has been bothering me: the RD-108 engine is specified with a rated VAC thrust of 918 kN. Does this value include the thrust of the verniers (rated VAC thrust of ~38 kN - 152 kN for all 4)? Most sources just reference the value for the "RD-108" and not separately.

I know that they reference the thrust for the complete package but does this package include the verniers? They are separate engines after all.

@NathanKell
Copy link
Member Author

@NathanKell NathanKell commented on 8fd1716 Jun 9, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.