Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musescore (darwin): 2.0.3 -> 2.1 #26297

Merged
merged 2 commits into from Nov 13, 2017
Merged

musescore (darwin): 2.0.3 -> 2.1 #26297

merged 2 commits into from Nov 13, 2017

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jun 1, 2017 •
edited

N.B. I've very amenable to alternative solutions to the "no patch in this version" problem.

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@copumpkin
Copy link
Member

@yurrriq I'm fine with this but here's an alternative if you're looking for one: stick the components into a list and then use concatStringsSep "." to construct the version. If the patch version is there, you just get an extra element in the list.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jun 1, 2017
@yurrriq yurrriq force-pushed the update/pkgs/applications/audio/musescore branch from 0991d90 to 1be6c67 Compare June 13, 2017 04:31
@yurrriq
Copy link
Member Author

yurrriq commented Jun 13, 2017 •
edited

@copumpkin I've updated this to use concatStringsSep, tested the strategy against 2.0.3.1 locally, and rebased on master.

@yurrriq
Copy link
Member Author

yurrriq commented Nov 7, 2017

bump

@c0bw3b c0bw3b merged commit 51a8584 into NixOS:master Nov 13, 2017
@yurrriq
Copy link
Member Author

yurrriq commented Nov 13, 2017

Thanks!

@yurrriq yurrriq deleted the update/pkgs/applications/audio/musescore branch November 13, 2017 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yurrriq @copumpkin @pSub @LnL7 @c0bw3b