New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds THEME_COLORS, POSTS_CATEGORIES, POSTS_CATEGORY_*, and HUSL color functions #1981
Conversation
@@ -89,6 +89,10 @@ NAVIGATION_LINKS = ${NAVIGATION_LINKS} | |||
# Name of the theme to use. | |||
THEME = ${THEME} | |||
|
|||
# Primary color of your theme. This will be used to customize your theme and | |||
# auto-generate related colors in POSTS_CATEGORY_COLORS. Must be a HEX value. | |||
THEME_COLOR = '#5670d4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this color?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic light corporate blue were designed to be non-offensive and enduce trust. Sounds like a perfect candidate for a nonintrusive default if I ever heard one. Goes well with the default bootstrap3 theme. Feel free to suggest another.
# is assigned to each category based on shifting the hue of your THEME_COLOR | ||
# at least 7.5 % while leaving the lightness and saturation untouched in the | ||
# HUSL colorspace. You can overwrite colors by assigning them colors in HEX. | ||
POSTS_CATEGORY_COLORS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be commented out by default, along with POST_CATEGORY_DESCRIPTIONS and POST_CATEGORY_TITLE
functions available in themes (Issue #1980) Minor changes.
I think it should be ready to merge now. |
@ralsina have you got any time to look through this before merging? |
Tomorrow morning I will. |
LGTM. However, since sections is a new concept it needs documenting. I can do it myself since you already did the hard work of actually implementing them :-) |
Add Sections and related color functionality for theme authors
See Issue #1980 before proceeding.
Colors are not displayed anywhere just yet, except by adding a
<meta name="theme-color">
.