Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qbittorrent: fix build #31438

Merged
merged 1 commit into from Nov 9, 2017
Merged

qbittorrent: fix build #31438

merged 1 commit into from Nov 9, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 9, 2017 •
edited

Motivation for this change

Failing since #31357 because there is no $$[QT_INSTALL_BINS]/lrelease anymore. See qm_gen.pri.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
qbittorrent: fix build
ad84832 
Probably failing since NixOS#31357
@orivej orivej requested a review from ttuegel November 9, 2017 12:30
@orivej orivej merged commit ce33407 into NixOS:master Nov 9, 2017
@orivej orivej deleted the qbittorrent branch November 13, 2017 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@orivej