Fix multiple cves #31437
Closed
Fix multiple cves #31437
+69
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix is based on work at [1] which upstream seems to have implemented as seen at [2]. [1] https://github.com/antirez/redis/pull/4365 [2] antirez/redis@ffcf7d5
c0bw3b
added
1.severity: security
|
Yet another tool to list CVEs for our packages :-) |
|
Not just CVEs, also "upstream" version changes from e.g. release-monitoring.org... :-) |
|
That reminds me of https://github.com/Phreedom/nixpkgs-monitor |
|
cc @NixOS/security-notifications on both the specific fixes and the tool |
orivej
reviewed
Nov 11, 2017
|
|
||
| src = fetchFromGitHub { | ||
| owner = "Thomas-Tsai"; | ||
| repo = "partclone"; | ||
| rev = version; | ||
| sha256 = "0gw47pchqshhm00yf34qgxh6bh2jfryv0sm7ghwn77bv5gzwr481"; | ||
| sha256 = "1gw47pchqshhm00yf34qgxh6bh2jfryv0sm7ghwn77bv5gzwr481"; |
There was a problem hiding this comment.
This sha256 is invalid, it should be 0bv15i0gxym4dv48rgaavh8p94waryn1l6viis6qh5zm9cd08skg.
vcunat
added
the
9.needs: port to stable
vcunat
reviewed
Nov 11, 2017
| sha256 = "0jcjlx9ksdvxvjyxmyzscx9ar9992iy5icw0sc3n0p09qi4d6x1r"; | ||
| }) | ||
| ]; | ||
|
|
There was a problem hiding this comment.
For non-generated patches it seems better to use fetchurl, but let's keep this as it is.
vcunat
added a commit
that referenced
this pull request
Nov 11, 2017
|
Thank you for working on and merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I created a new tool to generate a list of packages affected by CVEs and started working through the list for the unstable channel.
This is just the ones that seemed fixable and where proper upstream commits/patches could be found.
The complete list from my WIP tool can be found here.
Some of the commits might be worth backporting to stable.
I am not so sure about the others since they might involve bumping versions. Is that something we do for an already released stable version?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)