czmq: Fix build with gcc-7 #31765
czmq: Fix build with gcc-7 #31765
Conversation
| url = https://patch-diff.githubusercontent.com/raw/zeromq/czmq/pull/1618.patch; | ||
| sha256 = "1dssy7k0fni6djail8rz0lk8p777158jvrqhgn500i636gkxaxhp"; | ||
| }) | ||
| ]; |
There was a problem hiding this comment.
Doesn't it apply to czmq 3?
There was a problem hiding this comment.
No. Had to be backported.
The patch attached to czmq3 is the same as czmq4, just backported to apply.
|
I wonder whether to merge gcc7-specific fixes to master or just to |
|
Unless we may decide not to upgrade to GCC 7, I'd prefer to commit to master and staging; or commit to gcc-7 and periodically merge gcc-7 (except the gcc upgrade) to staging. This simplifies maintenance and ensures that the patches receive some user testing before the final switch to gcc 7. |
|
OK, to master and staging. We would better not merge gcc-7 to staging yet, as staging is meant for things ready to be merged to master. And this week I even see lots of failures on staging... |
Motivation for this change
See tracking issue #31747
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)