Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve rustPlatform example #31766

Merged
merged 1 commit into from
Nov 17, 2017
Merged

doc: improve rustPlatform example #31766

merged 1 commit into from
Nov 17, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Nov 17, 2017

Motivation for this change

Currently quite a few of rust packages contain:

with rustPlatform;
 
buildRustPackage rec {

where the only used rustPlatform attr is buildRustPackage. This is nonsensical and confusing, and it seems to stem from the example in the manual.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 17, 2017
@Mic92 Mic92 merged commit 348f938 into NixOS:master Nov 17, 2017
@orivej orivej deleted the rust-doc branch December 15, 2017 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants