Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: 2.0.0 -> 2.0.1 (fixes vagrant with virtualbox 5.2) #31768

Merged
merged 2 commits into from Nov 17, 2017
Merged

vagrant: 2.0.0 -> 2.0.1 (fixes vagrant with virtualbox 5.2) #31768

merged 2 commits into from Nov 17, 2017

Conversation

andir
Copy link
Member

@andir andir commented Nov 17, 2017 •
edited by grahamc

Motivation for this change

With the recent virtualbox bump to 5.2 vagrant is no longer able to interface with virtualbox. Version 2.01 fixes that.

While doing that I figured that the custom rake gem doesn't seem to have any purpose anymore. Our standard pkgs.rake works just as well so that is the 2nd commit in this PR.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
vagrant: 2.0.0 -> 2.0.1
3f4eb16 
Due to the virtualbox bump to version 5.2 vagrant was no longer able to
interface with virtualbox. Version 2.0.1 supports virtualbox 5.2.
@andir
vagrant: removed custom rake gem
e427e84
@andir
Copy link
Member Author

andir commented Nov 17, 2017

@grahamc is there a way to get the output of @GrahamcOfBorg? The command that I can see in the tooltip of "grahamcofborg-eval-package-list" works on my machines (TM).

@grahamc
Copy link
Member

grahamc commented Nov 17, 2017

Hey @andir, a couple things:

  1. if you rebase this branch to master, it'll definitely fail. the piping of stderr to /dev/null isn't going to help people figure this out, so I'll remove that.
  2. The failure is because master fails to evaluate packages: i3status-rust: init at 0.9.0.2017-11-09 #31626 and yours is based on master. Orivej is sending a patch for this right now. When that happens, we'll rerun the checks for this branch.

@andir
Copy link
Member Author

andir commented Nov 17, 2017

Thanks for the input. I used the latest unstable channel as base for my PR - as I do always.

So the checks succeeded now. Without anyone touching master and this PR.. So your theory sounds a bit strange to me. Maybe I am missing something.

@grahamc
Copy link
Member

grahamc commented Nov 17, 2017 •
edited

@GrahamcOfBorg build vagrant

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 17, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/fvqx1j3h5hg7bmj4w30kkdcmrpkj9085-vagrant-2.0.1

@grahamc
Copy link
Member

grahamc commented Nov 17, 2017

LGTM should we backport this?

@andir
Copy link
Member Author

andir commented Nov 17, 2017 •
edited

It probably doesn't hurt since it is basically just bug fixing and adding support for ruby 2.4 (but previous versions are still supported (we've 2.3 as "stable" currently)).
The relevant changelog is

## 2.0.1 (November 2, 2017)

FEATURES:

  - core: Introduce Ruby 2.4 to Vagrant [GH-9102]
  - providers/virtualbox: Virtualbox 5.2 support [GH-8955]

IMPROVEMENTS:

  - command/destroy: Introduce parallel destroy for certain providers [GH-9127]
  - communicators/winrm: Include APIPA check within ready check [GH-8997]
  - core: Clear POSIXLY_CORRECT when using optparse [GH-8685]
  - docs: Add auto_start_action and auto_stop_action to docs. [GH-9029]
  - docs: Fix typo in box format doc [GH-9100]
  - provisioners/chef: Handle chef provisioner reboot request [GH-8874]
  - providers/salt: Support Windows Salt Minions greater than 2016.x.x [GH-8926]
  - provisioners/salt: Add wget to bootstrap_salt options when fetching installer file [GH-9112]
  - provisioners/shell: Use ui.detail for displaying output [GH-8983]
  - util/downloader: Use CURL_CA_BUNDLE environment variable [GH-9135]

BUG FIXES:

  - communicators/ssh: Retry on Errno::EPIPE exceptions [GH-9065]
  - core: Rescue more exceptions when checking if port is open [GH-8517]
  - guests/solaris11: Inherit from Solaris guest and keep solaris11 specific methods [GH-9034]
  - guests/windows: Split out cygwin path helper for msys2/cygwin paths and ensure cygpath exists [GH-8972]
  - guests/windows: Specify expected shell when executing on guest (fixes winssh communicator usage) [GH-9012]
  - guests/windows: Include WinSSH Communicator when using insert_public_key [GH-9105]
  - hosts/windows: Check for vagrant.exe when validating versions within WSL [GH-9107, GH-8962]
  - providers/docker: Isolate windows check within executor to handle running through VM [GH-8921]
  - providers/hyper-v: Properly invoke Auto stop action [GH-9000]
  - provisioners/puppet: Fix winssh communicator support in puppet provisioner [GH-9014]
  - virtualbox/synced_folders: Allow synced folders to contain spaces in the guest path [GH-8995]

(https://github.com/hashicorp/vagrant/blob/v2.0.1/CHANGELOG.md#201-november-2-2017)

@grahamc
Copy link
Member

grahamc commented Nov 17, 2017

This patch was applied to master: d7aefea and I triggered the evaluation checks to run again. That is why it started passing again :)

@andir
Copy link
Member Author

andir commented Nov 17, 2017

Ahhh, okay.. Since I didn't know the exact error I didn't think of that fixing it... Totally makes sense now :-)

@grahamc grahamc merged commit 5af8c93 into NixOS:master Nov 17, 2017
GrahamcOfBorg
GrahamcOfBorg reviewed Nov 17, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/msvcc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/depcomp: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/missing: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/compile: interpreter directive changed from " /bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/build-ios.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/opt/vagrant/embedded/gems/gems/ffi-1.9.18/ext/ffi_c/libffi/src/arm/gentramp.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/sh"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1/share/bash-completion/completions/vagrant: interpreter directive changed from "/bin/bash" to "/nix/store/hh833qm6lgb6cgr7z9vxkb72wikr4wwz-bash-4.4-p12/bin/bash"
/nix/store/33i1hi661ynnzka89l42mqnqfzdnsdnb-vagrant-2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @grahamc @GrahamcOfBorg