Added DLL loading capability in windows to the std lib. #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimenus
force-pushed
the
dll-load
branch
3 times, most recently
from
8654fb2
to
12835e0
Compare
andrewrk
reviewed
Nov 17, 2017
test/compare_output.zig
Outdated
| @@ -444,4 +444,18 @@ pub fn addCases(cases: &tests.CompareOutputContext) { | |||
|
|
|||
| tc | |||
| }); | |||
|
|
|||
| cases.add("bad dll name on windows", | |||
There was a problem hiding this comment.
can you make this a behavior test? look at test/behavior.zig and test/cases/*
generally we prefer these kind of tests when possible because they run much faster than compare_output tests.
There was a problem hiding this comment.
better yet, add this test somewhere in std/ because that's what it's testing.
behavior tests are for language features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added DLL loading capability in windows to the std lib.
Will need to revisit this when we solve #534