Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use {{yield}} outside a macro #5307

Merged
merged 1 commit into from Nov 22, 2017
Merged

Don't use {{yield}} outside a macro #5307

merged 1 commit into from Nov 22, 2017

Conversation

makenowjust
Copy link
Contributor

Fixed #5305

luislavena
luislavena suggested changes Nov 17, 2017
View reviewed changes
src/compiler/crystal/macros/interpreter.cr Outdated
end

record MacroVarKey, name : String, exps : Array(ASTNode)?

def initialize(@program : Program,
@scope : Type, @path_lookup : Type, @location : Location?,
@vars = {} of String => ASTNode, @block : Block? = nil, @def : Def? = nil)
@vars = {} of String => ASTNode, @block : Block? = nil, @def : Def? = nil,
@in_macro = false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@makenowjust minor indentation issue, formatter issue 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry

@makenowjust makenowjust force-pushed the fix/crystal/cant-use-yield-outside-a-macro branch from bf0480f to 580dd89 Compare November 17, 2017 12:56
@makenowjust makenowjust force-pushed the fix/crystal/cant-use-yield-outside-a-macro branch from 580dd89 to 70f162d Compare November 17, 2017 13:29
@RX14 RX14 added this to the Next milestone Nov 22, 2017
@RX14 RX14 merged commit f311861 into crystal-lang:master Nov 22, 2017
@makenowjust makenowjust deleted the fix/crystal/cant-use-yield-outside-a-macro branch November 22, 2017 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luislavena luislavena luislavena approved these changes

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler
Projects
None yet
Milestone
0.24.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makenowjust @luislavena @ysbaddaden @RX14