Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] nixos/syncthing: change group from nogroup to syncthing #31990

Closed
wants to merge 1 commit into from
Closed

[WIP] nixos/syncthing: change group from nogroup to syncthing #31990

wants to merge 1 commit into from

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

Files should not be owned by nogroup. The syncthing group already exist,
let's use it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
nixos/syncthing: change group from nogroup to syncthing
edc41a3 
Files should not be owned by nogroup. The syncthing group already exist,
let's use it.
@orivej
Copy link
Contributor

orivej commented Nov 24, 2017

It seems that syncthing group does not exist when cfg.user != defaultUser.

@bjornfor bjornfor changed the title nixos/syncthing: change group from nogroup to syncthing [WIP] nixos/syncthing: change group from nogroup to syncthing Nov 24, 2017
@bjornfor
Copy link
Contributor Author

Oh... (Added [WIP] to PR title.)

@jabranham jabranham mentioned this pull request Feb 7, 2019
Open
89 tasks
@bachp
Copy link
Member

bachp commented Jun 16, 2019

@bjornfor Are you still working on this?

@bjornfor
Copy link
Contributor Author

@bachp: Not actively. I'm severly lagging behind master...

@bjornfor
Copy link
Contributor Author

Closing since this was fixed in 8317663. Thanks!

@bjornfor bjornfor closed this Jul 24, 2019
@bjornfor bjornfor deleted the nixos-syncthing-group branch October 17, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bjornfor @orivej @bachp @FRidh @GrahamcOfBorg