fetchGit: Ignore tarballTtl if rev is set and not in the repo. #1698
Conversation
|
Thanks for such a quick fix! I guess the only thing that could be added to the PR would be a test for the issue here: |
|
@knedlsepp Any interest in adding the test yourself? You can then open a PR against my branch and I can add it to this PR. |
|
@shlevy Yes I'm currently trying to do it. Please excuse however that even though the patch will be relatively simple, I currently predict that this will take me more than a few minutes since I'm just in the midst of trying to get the thing compiling inside the nix-shell. |
shlevy
force-pushed
the
fetchGit-fast-revision-update
branch
from
cfbb3e7
to
eedbc4e
Compare
|
@knedlsepp Oops! Didn't see your response, already done 😮 |
|
@shlevy: Thanks! I guess I'll try to contribute some code the next time I stumble across an issue. |
|
@edolstra ping |
|
@edolstra barring any objections I'll merge next week |
Fixes #1697.