Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing documentation for copyFileFromHost in NixOS tests #31972

Merged
merged 1 commit into from Nov 24, 2017

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Nov 23, 2017

Motivation for this change

Documentation was missing :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

<varlistentry>
<term><methodname>copyFileFromHost</methodname></term>
<listitem><para>Copies a file from host to machine, e.g.,
<literal>copyFileFromHost("myfile", "/etc/my/important/file")</literal>.</para></listitem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more about the params, like the left param is the source file on the host, relative to what, and the second file is the destination on the VM?

@grahamc
Copy link
Member

grahamc commented Nov 23, 2017

@GrahamcOfBorg eval

@bkchr bkchr force-pushed the copyfilefromhost_missing_documentation branch from 22096b7 to 1200f9b Compare November 23, 2017 14:51
@grahamc grahamc merged commit 0726cd6 into NixOS:master Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants