Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inginious 0.40 #31975

Closed
wants to merge 2 commits into from
Closed

Inginious 0.40 #31975

wants to merge 2 commits into from

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Nov 23, 2017

Motivation for this change

unbreak the package so that the module can be evaluated. See the comments on 6111168

/cc @layus @grahamc

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@zimbatm
pythonPackages.psutil: 4.3.0 -> 4.4.2
4f2c973 
This is the last 4.x release before 5.x
@zimbatm
inginious: 0.3a2.dev0 -> 0.4.0
984e50c 
This is wholy untested. It's only propery is that it builds and can be
markes as unbroken, so that the related module can be evaluated.
@zimbatm zimbatm requested a review from FRidh as a code owner November 23, 2017 15:29
zimbatm referenced this pull request Nov 23, 2017
@zimbatm
inginious: mark as broken
6111168 
The project doesn't exist on github anymore.
@zimbatm zimbatm self-assigned this Nov 23, 2017
FRidh
FRidh requested changes Nov 23, 2017
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -14851,12 +14851,13 @@ in {
psd-tools = callPackage ../development/python-modules/psd-tools { };

psutil = buildPythonPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this bump will require a separate PR

@zimbatm
Copy link
Member Author

zimbatm commented Nov 23, 2017

nox-review is failing with:

warning: no previously-included files matching '*.py[co]' found anywhere in distribution
no previously-included directories found matching 'docs/_build'
builder for ‘/nix/store/q5pqx45v5l4c8v752l5c44pl14a0njxf-python2.7-oslo.reports-0.6.0.drv’ failed with exit code 1

@layus
Copy link
Member

layus commented Nov 23, 2017

Could we remove this package and the corresponding module ? It is a tool under development with a tendency to use cutting edge versions of all the python dependencies. It is quite difficult to maintain, and I have little time to do so ATM.

@zimbatm zimbatm mentioned this pull request Nov 23, 2017
Closed
8 tasks
@layus
Copy link
Member

layus commented Nov 23, 2017

Plus, @grahamc fixed the module eval in #31973

@FRidh
Copy link
Member

FRidh commented Nov 24, 2017

psutil is in staging

@zimbatm zimbatm closed this Nov 24, 2017
@zimbatm zimbatm deleted the inginious-0.40 branch November 24, 2017 21:26
@dotlambda dotlambda mentioned this pull request Jul 19, 2018
Merged
9 tasks
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Jul 19, 2018
@Ma27
inginious: remove
0adca53 
Fallout of 9db7f15ea3ce57eee25458daf87cce7a04ea98b2 which removed
simpleldap.

@layus suggests to remove:

* NixOS#43782 (comment)
* NixOS#31975 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees

@zimbatm zimbatm

Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @layus @FRidh @GrahamcOfBorg