rustc: 1.21.0 -> 1.22.1 #31982

zimbatm · 2017-11-23T18:21:50Z

Motivation for this change

duh

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

zimbatm · 2017-11-23T18:22:12Z

can anyone test it on macOS?

grahamc · 2017-11-23T18:23:48Z

@GrahamcOfBorg build rustc

zimbatm · 2017-11-23T18:23:50Z

@GrahamcOfBorg eval

grahamc · 2017-11-23T18:24:27Z

No need to call eval manually, unless something went wrong mysteriously with the first one :)

zimbatm · 2017-11-23T18:24:48Z

alright :)

GrahamcOfBorg

Failure for system: x86_64-darwin

removed 'src/test/debuginfo/var-captured-in-sendable-closure.rs'
removed 'src/test/debuginfo/var-captured-in-stack-closure.rs'
configuring
configure flags: --prefix=/nix/store/sg80860pldx9g6d8awfdxidl17l9yq92-rustc-1.22.1 --release-channel=stable --enable-local-rust --local-rust-root=/nix/store/d5fxqy76rqscyaw9p1mnngkz86wq8pv2-rustc-bootstrap-1.21.0 --enable-rpath --enable-vendor --disable-locked-deps --default-linker=/nix/store/4z8vhlqrnfpjr963pgxhccyzhgpjflw7-clang-wrapper-4.0.1/bin/cc --default-ar=/nix/store/09jllpa592yk1yiz018yv6s5jjmzymf0-cctools-binutils-darwin/bin/ar --enable-clang
configure: processing command line
configure:
configure: error: Option '--enable-clang' is not recognized
builder for '/nix/store/6m5wrj6bhzy2kz6lb70fbq3wws8chj74-rustc-1.22.1.drv' failed with exit code 1
error: build of '/nix/store/6m5wrj6bhzy2kz6lb70fbq3wws8chj74-rustc-1.22.1.drv' failed on ‘mac1’
error: build of ‘/nix/store/6m5wrj6bhzy2kz6lb70fbq3wws8chj74-rustc-1.22.1.drv’ failed

zimbatm · 2017-11-23T18:29:44Z

So cargo-vendor is supposed to support git dependencies now. I have https://github.com/zimbatm/nixpkgs/tree/alacritty-git-deps to demonstrate the concept but there is some complication. For some reason it still needs a registry:

error: no source URL specified for source.https://github.com/jwilm/libfontconfig, need either registry or local-registry defined

/cc @Mic92

LnL7 · 2017-11-23T20:04:04Z

@zimbatm Let me know if you want help for the darwin changes.

GrahamcOfBorg

Success for system: x86_64-linux

/nix/store/15vi7q9i44gwxghkjkf1234gk61ih13z-rustc-1.22.1/lib/rustlib/uninstall.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-rustc-1.22.1.drv-0 in /nix/store/15vi7q9i44gwxghkjkf1234gk61ih13z-rustc-1.22.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/i7w8dx7w5pvck7cq04n681b9br7rdvlc-rustc-1.22.1-man
gzipping man pages under /nix/store/i7w8dx7w5pvck7cq04n681b9br7rdvlc-rustc-1.22.1-man/share/man/
patching script interpreter paths in /nix/store/i7w8dx7w5pvck7cq04n681b9br7rdvlc-rustc-1.22.1-man
checking for references to /tmp/nix-build-rustc-1.22.1.drv-0 in /nix/store/i7w8dx7w5pvck7cq04n681b9br7rdvlc-rustc-1.22.1-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/frm319125dh3vg3y0xsysr85h2sswa8d-rustc-1.22.1-doc
patching script interpreter paths in /nix/store/frm319125dh3vg3y0xsysr85h2sswa8d-rustc-1.22.1-doc
checking for references to /tmp/nix-build-rustc-1.22.1.drv-0 in /nix/store/frm319125dh3vg3y0xsysr85h2sswa8d-rustc-1.22.1-doc...
/nix/store/15vi7q9i44gwxghkjkf1234gk61ih13z-rustc-1.22.1

zimbatm · 2017-11-24T10:49:43Z

@LnL7 if you could nox-review on Darwin it would be great!

Ma27 · 2017-11-24T10:55:23Z

@zimbatm not sure if I got your comment right, but is there any way to fix the resolution issue with git dependencies in Cargo? I tried to package uutils/coreutils for @NeQuissimus once and I failed because of such Cargo problems...

Mic92 · 2017-11-24T10:58:01Z

@Ma27 I am not sure what cargo-vendor does at the moment, but according to the documentation, should write an source replacement entry like this: https://github.com/alexcrichton/cargo/blob/5b08b8fe1019147fe489db17a9a8ae7ebe97f9e9/src/doc/source-replacement.md#configuration

orivej · 2017-11-24T11:16:44Z

@zimbatm Why do you mark bokeh as broken? It builds on Linux: https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=bokeh

orivej · 2017-11-24T11:39:12Z

rustc fails to build on Darwin:

configuring                                    
configure flags: --prefix=/nix/store/sg80860pldx9g6d8awfdxidl17l9yq92-rustc-1.22.1 --release-channel=stable --enable-local-rust --local-rust-root=/nix/store/d5fxqy76rqscy
aw9p1mnngkz86wq8pv2-rustc-bootstrap-1.21.0 --enable-rpath --enable-vendor --disable-locked-deps --default-linker=/nix/store/4z8vhlqrnfpjr963pgxhccyzhgpjflw7-clang-wrapper
-4.0.1/bin/cc --default-ar=/nix/store/09jllpa592yk1yiz018yv6s5jjmzymf0-cctools-binutils-darwin/bin/ar --enable-clang
configure: processing command line                                
configure:                                        
configure: error: Option '--enable-clang' is not recognized     
builder for ‘/nix/store/6m5wrj6bhzy2kz6lb70fbq3wws8chj74-rustc-1.22.1.drv’ failed with exit code 1

zimbatm · 2017-11-24T14:28:15Z

@orivej for bokeh, I am getting the following error at the check phase:

  File "bokeh/models/annotations.py", line 15, in <module>
    from ..core.property_mixins import FillProps, LineProps, TextProps
ImportError: cannot import name FillProps

orivej · 2017-11-25T08:56:21Z

@zimbatm Are you building on NixOS or other Linux? With or without sandboxing? Could you attach the complete build log? Nevertheless, since bokeh builds on Hydra (and my machines), it should not be disabled in this PR. (I'm also trying to restore the support for Darwin by fixing the build of python.pkgs.selenium.)

To fix the build phase on Darwin, delete the line with "--enable-clang". Then the build phase succeeds, but one of the tests fails… (I've confirmed that rust 1.21.0 builds fine on the same machine.)

FRidh · 2017-11-25T09:03:53Z

pkgs/development/python-modules/bokeh/default.nix

@@ -75,6 +75,7 @@ buildPythonPackage rec {
  '';

  meta = {
+    broken = true;


please remove this. As @orivej pointed out, it builds, and if it doesn't, it needs to be fixed outside this PR.

zimbatm · 2017-11-25T14:08:50Z

@Ma27 let's discuss the cargo git situation in the next PR, once rust itself has been updated. Basically it's not working either after the update so it will need to be investigated.

@orivej removed --enable-clang, can you give me the next failure?

@orivej @FRidh re-enabled bokeh but it's still failing for me on NixOS with sandbox enabled (EDIT: actually it's also failing on master for me). There is no maintainer for the package so either become a maintainer or I will mark it as broken.

Ma27 · 2017-11-25T20:57:28Z

@zimbatm great! Just feel free to ping me if there's anything I could do to fix this cargo issue :)

orivej · 2017-11-25T22:31:49Z

Here are my two attempts to build rust 1.22.1 on Darwin: rustc-1.22.1-try1.log, rustc-1.22.1-try2.log. For comparison, the log of building rust 1.21.0: rustc-1.21.0.log.

orivej · 2017-11-25T22:46:38Z

re-enabled bokeh but it's still failing for me on NixOS with sandbox enabled (EDIT: actually it's also failing on master for me). There is no maintainer for the package so either become a maintainer or I will mark it as broken.

You should not mark the package as broken when you do not know why it is breaking and it works for everyone but you. I have already posted the link that proves that Hydra can build it on master. Now I have added myself to its maintainers. Please open a separate issue and attach the complete build log.

* removed --enable-clang as it has disappeared * removed old fixes that have been integrated in upstream

cargo-vendor generates almost the right cargo config. Store it with the vendored files and patch it on use. This allows to re-use the generated config when using git dependencies.

zimbatm · 2017-12-26T18:48:57Z

@GrahamcOfBorg build rustc

GrahamcOfBorg

Failure for system: x86_64-darwin

dyld: Library not loaded: /usr/lib/libresolv.9.dylib
  Referenced from: /nix/store/ifj40783ymkz6z1krkxncc5b3vd4xciv-rustc-bootstrap-1.21.0/bin/cargo
  Reason: no suitable image found.  Did find:
	/usr/lib/libresolv.9.dylib: file system sandbox blocked stat()
	/usr/lib/libresolv.9.dylib: file system sandbox blocked stat()
failed to run: /nix/store/ifj40783ymkz6z1krkxncc5b3vd4xciv-rustc-bootstrap-1.21.0/bin/cargo build --manifest-path /private/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/bootstrap/Cargo.toml --frozen
Build completed unsuccessfully in 0:00:00
make: *** [Makefile:22: all] Error 1
builder for '/nix/store/v28jmfm6lzahm6plgm0kspllb6h2905m-rustc-1.22.1.drv' failed with exit code 2
error: build of '/nix/store/v28jmfm6lzahm6plgm0kspllb6h2905m-rustc-1.22.1.drv' failed

LnL7 · 2017-12-26T19:32:07Z

That's a sandboxing issue with the bootstrap rust.

GrahamcOfBorg

Failure for system: x86_64-linux

   Compiling rustc_const_math v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/libproc_macro)
     Running `/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/bootstrap/debug/rustc --crate-name rustc_const_math src/librustc_const_math/lib.rs --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=889256c9b205274c -C extra-filename=-889256c9b205274c --out-dir /tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.so --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.rlib --extern rustc_apfloat=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_apfloat-5d45970390c14d77.rlib --extern syntax=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-53b19959339be2e1.so`
     Running `/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/bootstrap/debug/rustc --crate-name proc_macro src/libproc_macro/lib.rs --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=b692e9730dc03dbb -C extra-filename=-b692e9730dc03dbb --out-dir /tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern syntax=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-53b19959339be2e1.so --extern rustc_errors=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-11e9af32db529b23.so --extern syntax_pos=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-ab39309cb177cfa9.so`
     Running `/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/bootstrap/debug/rustc --crate-name rustc_back src/librustc_back/lib.rs --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 --cfg 'feature="jemalloc"' -C metadata=cfd0acd7d63eb15a -C extra-filename=-cfd0acd7d63eb15a --out-dir /tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern log=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-4df2ac3c730deffe.rlib --extern syntax=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-53b19959339be2e1.so --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.so --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.rlib`
   Compiling syntax_ext v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/libsyntax_ext)
     Running `/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/bootstrap/debug/rustc --crate-name syntax_ext src/libsyntax_ext/lib.rs --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=7c279b970a4f5f05 -C extra-filename=-7c279b970a4f5f05 --out-dir /tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern syntax_pos=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-ab39309cb177cfa9.so --extern fmt_macros=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libfmt_macros-1c8657df6ff5827d.so --extern proc_macro=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libproc_macro-b692e9730dc03dbb.so --extern rustc_errors=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-11e9af32db529b23.so --extern syntax=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-53b19959339be2e1.so`
     Running `/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/bootstrap/debug/rustc --crate-name rustc src/librustc/lib.rs --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=374f8f4c01be1515 -C extra-filename=-374f8f4c01be1515 --out-dir /tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern arena=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libarena-decd8d77455b0c80.so --extern rustc_data_structures=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-e45fbf0ffc34f408.so --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.so --extern serialize=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-2034a63f77802499.rlib --extern bitflags=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-1b562188bc4813f4.rlib --extern flate2=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libflate2-5c0f58ddcceae563.rlib --extern rustc_back=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_back-cfd0acd7d63eb15a.so --extern jobserver=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libjobserver-24a11d8dc7330e0b.rlib --extern syntax_pos=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-ab39309cb177cfa9.so --extern rustc_errors=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-11e9af32db529b23.so --extern fmt_macros=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libfmt_macros-1c8657df6ff5827d.so --extern log=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-4df2ac3c730deffe.rlib --extern rustc_const_math=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_const_math-889256c9b205274c.so --extern syntax=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax-53b19959339be2e1.so --extern graphviz=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libgraphviz-c33d669089553f12.so --extern owning_ref=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libowning_ref-e96f9935815845cc.rlib -L native=/tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/build/miniz-sys-4c32c51dbef5e6e1/out`
building of ‘/nix/store/x1r4yd5svh8qsyzx5b9f2gy10gvmpsld-rustc-1.22.1.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/x1r4yd5svh8qsyzx5b9f2gy10gvmpsld-rustc-1.22.1.drv’ failed

GrahamcOfBorg

Failure for system: aarch64-linux

Assembling stage1 compiler (aarch64-unknown-linux-gnu)
Building stage1 std artifacts (aarch64-unknown-linux-gnu -> aarch64-unknown-linux-gnu)
   Compiling cc v1.0.0
   Compiling unwind v0.0.0 (file:///build/rustc-1.22.1-src/src/libunwind)
   Compiling libc v0.2.31
   Compiling core v0.0.0 (file:///build/rustc-1.22.1-src/src/libcore)
   Compiling filetime v0.1.12
   Compiling build_helper v0.1.0 (file:///build/rustc-1.22.1-src/src/build_helper)
building of '/nix/store/zv3divslir38fikscza7x60lbp3fldm4-rustc-1.22.1.drv' timed out after 3600 seconds
error: build of '/nix/store/zv3divslir38fikscza7x60lbp3fldm4-rustc-1.22.1.drv' failed

zimbatm · 2017-12-27T14:15:15Z

@LnL7 are you going to look into it? The other platforms is just a timeout because rust takes a long time to compile.

The last change I pushed allows for git dependencies in the Cargo.lock, but it will mean updating all the cargoSha256 again. I will do it but I want to get rust sorted out first.

LnL7 · 2017-12-27T20:38:27Z

I'm looking at the sandbox impurity, but I'm fine with merging this if it works without.

orivej · 2017-12-29T07:00:51Z

Rust 1.21.0 has one test that occasionally fails on darwin (run-make/issue-26092: https://hydra.nixos.org/job/nixpkgs/trunk/rustc.x86_64-darwin/all). Rust 1.22.1 has three failing tests and IIRC at least two of them always fail on darwin (run-make/issue-26092 is not one of the three).

LnL7 · 2018-01-08T22:29:47Z

Sorry for the long delay. I fixed the sandboxing issues on master and pushed a fixed the 1.22.1 build.

globin · 2018-01-08T22:55:13Z

@GrahamcOfBorg build rustc

GrahamcOfBorg

Failure for system: x86_64-darwin

--     0

 55 4743k   55 2611k    0     0  2611k      0  0:00:01 --:--:--  0:00:01 6765k

100 4743k  100 4743k    0     0  474
3k      0  0:00:
0
1 --:--:--  0:00:01 7
650k

cannot build derivation ‘/nix/store/iy9snl3c0f6i0gya4as8sval90bb6ywx-rustc-1.22.1.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/iy9snl3c0f6i0gya4as8sval90bb6ywx-rustc-1.22.1.drv’ failed

GrahamcOfBorg

Failure for system: x86_64-linux

   Compiling rls-data v0.10.0
   Compiling rustc_llvm v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/librustc_llvm)
   Compiling syntax_pos v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/libsyntax_pos)
   Compiling flate2 v0.2.20
   Compiling rustc_errors v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/librustc_errors)
   Compiling rustc_const_math v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/librustc_const_math)
   Compiling proc_macro v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/libproc_macro)
   Compiling syntax_ext v0.0.0 (file:///tmp/nix-build-rustc-1.22.1.drv-0/rustc-1.22.1-src/src/libsyntax_ext)
building of ‘/nix/store/dak1ljnizgva82h1bwlfj3kmzp615zpp-rustc-1.22.1.drv’ timed out after 1800 seconds
error: build of ‘/nix/store/dak1ljnizgva82h1bwlfj3kmzp615zpp-rustc-1.22.1.drv’ failed

GrahamcOfBorg

Failure for system: aarch64-linux

   Compiling rustc_typeck v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_typeck)
   Compiling rustc_resolve v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_resolve)
   Compiling rustc_lint v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_lint)
   Compiling rustc_passes v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_passes)
   Compiling rustc_mir v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_mir)
   Compiling rustc_save_analysis v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_save_analysis)
   Compiling rustc_privacy v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_privacy)
   Compiling rustc_borrowck v0.0.0 (file:///build/rustc-1.22.1-src/src/librustc_borrowck)
building of '/nix/store/ad4pi3i01xj1h389cn71v711mprgq123-rustc-1.22.1.drv' timed out after 3200 seconds
error: build of '/nix/store/ad4pi3i01xj1h389cn71v711mprgq123-rustc-1.22.1.drv' failed

zimbatm · 2018-01-09T13:49:46Z

@globin all the cargoSha256 need to be fixed now. You can revert 71064ac and I will make another PR for the git support.

zimbatm requested a review from FRidh as a code owner November 23, 2017 18:27

GrahamcOfBorg reviewed Nov 23, 2017

View reviewed changes

GrahamcOfBorg added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Nov 23, 2017

GrahamcOfBorg reviewed Nov 24, 2017

View reviewed changes

FRidh reviewed Nov 25, 2017

View reviewed changes

zimbatm force-pushed the rust-1.22.1 branch from ef7d6b9 to cb908ef Compare November 25, 2017 11:36

pSub added the 8.has: package (update) label Nov 25, 2017

zimbatm mentioned this pull request Nov 25, 2017

Really obscure rust crash when compiling seemingly innocent library #27370

Closed

orivej mentioned this pull request Nov 27, 2017

cargo test with RUST_BACKTRACE causes SIGBUS rust-lang/rust#45731

Closed

zimbatm force-pushed the rust-1.22.1 branch from cb908ef to 490944c Compare December 20, 2017 23:37

rustc: 1.21.0 -> 1.22.1

88884dd

* removed --enable-clang as it has disappeared * removed old fixes that have been integrated in upstream

zimbatm added 2 commits December 26, 2017 18:46

cargo: 0.22.0 -> 0.23.0

5327cec

rust: store the cargo-vendor config

71064ac

cargo-vendor generates almost the right cargo config. Store it with the vendored files and patch it on use. This allows to re-use the generated config when using git dependencies.

zimbatm force-pushed the rust-1.22.1 branch from 490944c to 71064ac Compare December 26, 2017 18:48

GrahamcOfBorg reviewed Dec 26, 2017

View reviewed changes

LnL7 self-assigned this Dec 26, 2017

GrahamcOfBorg reviewed Dec 26, 2017

View reviewed changes

rustc: disable failing tests on darwin

8096c00

GrahamcOfBorg reviewed Jan 8, 2018

View reviewed changes

globin merged commit b195d8a into NixOS:master Jan 9, 2018

pbogdan mentioned this pull request Jan 9, 2018

(all?) rust projects need hashes updated, broken by recent change #33647

Closed

ghost mentioned this pull request Jan 19, 2018

[WIP] Rust platform improvements #34034

Closed

zimbatm deleted the rust-1.22.1 branch February 22, 2019 21:07

rustc: 1.21.0 -> 1.22.1 #31982

rustc: 1.21.0 -> 1.22.1 #31982

Conversation

zimbatm commented Nov 23, 2017 • edited

Motivation for this change

Things done

zimbatm commented Nov 23, 2017

grahamc commented Nov 23, 2017 • edited

zimbatm commented Nov 23, 2017

grahamc commented Nov 23, 2017

zimbatm commented Nov 23, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

zimbatm commented Nov 23, 2017 • edited

LnL7 commented Nov 23, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

zimbatm commented Nov 24, 2017

Ma27 commented Nov 24, 2017

Mic92 commented Nov 24, 2017

orivej commented Nov 24, 2017 • edited

orivej commented Nov 24, 2017

zimbatm commented Nov 24, 2017

orivej commented Nov 25, 2017

FRidh Nov 25, 2017

Choose a reason for hiding this comment

zimbatm commented Nov 25, 2017 • edited

Ma27 commented Nov 25, 2017

orivej commented Nov 25, 2017

orivej commented Nov 25, 2017

zimbatm commented Dec 26, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

LnL7 commented Dec 26, 2017

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

zimbatm commented Dec 27, 2017 • edited

LnL7 commented Dec 27, 2017

orivej commented Dec 29, 2017

LnL7 commented Jan 8, 2018

globin commented Jan 8, 2018

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

zimbatm commented Jan 9, 2018

zimbatm commented Nov 23, 2017 •

edited

grahamc commented Nov 23, 2017 •

edited

zimbatm commented Nov 23, 2017 •

edited

orivej commented Nov 24, 2017 •

edited

zimbatm commented Nov 25, 2017 •

edited

zimbatm commented Dec 27, 2017 •

edited