Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inginious: fix options eval #31973

Merged
merged 1 commit into from Nov 23, 2017
Merged

inginious: fix options eval #31973

merged 1 commit into from Nov 23, 2017

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 23, 2017

When inginious was marked as broken, it caused options eval to fail.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc grahamc merged commit 8443352 into NixOS:master Nov 23, 2017
@grahamc grahamc deleted the options-fix-inginious branch November 23, 2017 14:43
@layus layus mentioned this pull request Nov 23, 2017
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @GrahamcOfBorg