Load libinput xorg config correctly #31995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
added
the
6.topic: GNOME
jtojnar
force-pushed
the
xserver-libinput
branch
from
50e498c
to
a6a5294
Compare
orivej
reviewed
Nov 24, 2017
| environment.etc = [ | ||
| (let cfgPath = "/X11/xorg.conf.d/40-libinput.conf"; in { | ||
| source = pkgs.xorg.xf86inputlibinput.out + "/share" + cfgPath; | ||
| target = cfgPath; |
There was a problem hiding this comment.
This works, but target is not expected to start with /.
In order for libinput to be used with Xorg, its configuration file needs to be added to environment similarly to how evdev one’s is. Closes: NixOS#31670
jtojnar
force-pushed
the
xserver-libinput
branch
from
a6a5294
to
6d0db1b
Compare
orivej
approved these changes
Nov 24, 2017
With libinput used for keyboard, base rules produce incorrect keyboard layouts. We are removing the option as recommended in the XKB configuration guide [1] to let X server choose the ruleset. It looks like it chooses evdev rules which seem to work for some reason [1]: https://www.x.org/releases/X11R7.6/doc/xorg-docs/input/XKB-Config.html#id2521360
orivej
force-pushed
the
xserver-libinput
branch
from
6d0db1b
to
c177b83
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
evdev is broken in GNOME (#31670) so we need to use libinput. GNOME enables libinput but the NixOS module did not load the Xorg configuration resulting in libinput not being used.
I also had switch the base xkb rules to evdev. Not sure what the difference is (asked here) but the latter does not seem to produce a mangled keyboard layout.
Things done
Tried with GNOME 3.24 and 3.26.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)