cudnn_cudatoolkit: use public NVIDIA mirror #31551

lukeadams · 2017-11-12T04:48:45Z

Motivation for this change

This PR dramatically simplifies the use of cudnn libraries on NixOS, which is used by most machine learning packages for gpu acceleration.

Previously, you would have to go through the NVIDIA developer portal and manually use nix-prefetch to add the tarballs to the store.

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

grahamc · 2017-11-12T12:45:20Z

It looks like we are allowed to distribute this lib as long as we include this copyright notice: https://gitlab.com/nvidia/cuda/blob/centos7/LICENSE#L1

lukeadams · 2017-11-12T16:14:07Z

Would including the license in the meta be acceptable? Or print it while the package is being built?
edit:

[nix-shell:~/Downloads/cuda-centos7-f6f245a7021a77b875df0165de9ba2e1cd3ea342]$ ~/.gem/ruby/2.3.0/bin/licensee
License: Other
Matched files: ["LICENSE"]
LICENSE:
  Content hash: 7b9a4f39cac1caafd2220db5aa686606a1267ae5
  Attribution: Copyright (c) 2017, NVIDIA CORPORATION. All rights reserved.
  License: Other
  Closest licenses:
    * BSD-3-Clause similarity: 97.87%

So it's a BSD license. I'll add that when I fix the hash.
Would this work?
license = licenses.unfree ++ licenses.bsd3;

grahamc · 2017-11-12T12:47:53Z

pkgs/development/libraries/science/math/cudnn/default.nix

    cudatoolkit = cudatoolkit7;
-    srcName = "cudnn-${cudatoolkit.majorVersion}-linux-x64-v${version}-prod.tgz";
+    srcName = "cudnn-${cudatoolkit.majorVersion}-linux-x64-v4.0-prod.tgz";
    sha256 = "0zgr6qdbc29qw6sikhrh6diwwz7150rqc8a49f2qf37j2rvyyr2f";


output path ‘/nix/store/f1mc7z50dw66vdzjkp3ds03p7kn765sl-cudnn-7.0-linux-x64-v4.0-prod.tgz’ has sha256 hash ‘01a4v5j4v9n2xjqcc4m28c3m67qrvsx87npvy7zhx7w8smiif2fd’ when ‘0zgr6qdbc29qw6sikhrh6diwwz7150rqc8a49f2qf37j2rvyyr2f’ was expected

Correct hash is 01a4v5j4v9n2xjqcc4m28c3m67qrvsx87npvy7zhx7w8smiif2fd
I'll update this PR friday

lukeadams · 2017-11-16T19:53:10Z

@grahamc I fixed the hash issue and re-tested (rebased on master), all successfully downloaded and built.

I added BSD3 to the license, but since the blobs being downloaded are unfree I left that in as well.

lukeadams · 2018-01-20T06:19:38Z

Rebased as of today

orivej · 2018-01-20T09:09:25Z

pkgs/development/libraries/science/math/cudnn/generic.nix

@@ -49,7 +44,7 @@ stdenv.mkDerivation rec {
  meta = with stdenv.lib; {
    description = "NVIDIA CUDA Deep Neural Network library (cuDNN)";
    homepage = "https://developer.nvidia.com/cudnn";
-    license = licenses.unfree;
+    license = [ licenses.unfree licenses.bsd3 ];


Does BSD3 apply to anything brought by this derivation, or is it just the license of Dockerfiles where you have found source URLs?

That's just the license in the Dockerfiles repo, which I now realize is definitely not the cudnn license. It looks like this is the actual license on the NVIDIA site.
I can add the license to licenses.nix, something like

nvidia-cudnn = { fullName = "NVIDIA SOFTWARE LICENSE AGREEMENT for cuDNN"; url = "http://docs.nvidia.com/deeplearning/sdk/pdf/cuDNN-SLA.pdf"; free = false; };

cudnn and friends have been posted to AUR with license proprietary

IMHO just keeping the old unfree is fine. Then it looks ready to merge.

lukeadams · 2018-01-20T23:33:44Z

@orivej I dropped the bsd3 commit

lukeadams · 2018-02-11T05:04:44Z

@orivej Rebased 2018-02-10

lukeadams · 2018-03-01T23:14:41Z

Rebased 2018-03-01

lukeadams · 2018-03-15T03:08:09Z

Rebased 2018-03-14, fixed merge conflict. Ready for review/merge

lukeadams · 2018-05-14T02:00:39Z

cc @orivej @grahamc
Rebased 2018-05-13

Since nox-review doesn't pick up the changes, the packages were tested with nix-build '<nixpkgs>' -I nixpkgs=/media/manual/nixpkgs-checkout/nixpkgs --no-out-link -A cudnn_cudatoolkit7 -A cudnn_cudatoolkit75 -A cudnn6_cudatoolkit8 -A cudnn_cudatoolkit8 -A cudnn_cudatoolkit9, which completes successfully.

lukeadams · 2018-06-27T02:15:15Z

@orivej @abbradar Are there any remaining issues? I just rebased and resolved the merge conflicts so it's still good to go afaik.

jb55

👍

lukeadams · 2018-07-17T19:15:50Z

cc @matthewbauer I just rebased and tested it again. Any chance we could get this merged?

matthewbauer · 2018-07-17T23:38:54Z

Yeah looks good. Just to verify though - do we need to do anything special with the license in this case? If you thunk it is redistributable we should do unfreeRedistributable to the license.

lukeadams · 2018-07-18T02:54:52Z

@matthewbauer orivej and I were talking about adding the CUDNN license on the nvidia site, but decided against it in favor of the license on the Dockerfile repo the source url is from.

Some debian maintainers were unsure of the redist status, so I'll probably leave it as unfree.
Would there be a way to have Hydra build+cache tensorflowWithCuda with it set as such?

orivej · 2018-07-18T03:24:03Z

Thank you and sorry for the delay!

lukeadams · 2018-07-18T03:25:21Z

:) no worries! Thanks to you both.

lukeadams · 2018-07-19T20:12:48Z

@matthewbauer Hey sorry to ping you again, but is there a way to have Hydra build the cudnn/CUDA/tensorflowWithGpu packages but not cache the output (i.e. so it gets listed on hydra.nixos.org, but without allowing redistribution)?

matthewbauer · 2018-07-19T21:03:16Z

No, I don't think there is a way to do that. Nix doesn't really separate out licenses of "buildPackages" vs "hostPackages". Everything either evaluates or not. This ties into some of the cross stuff & what I think @nh2 is working on. At one point in time you could put unfreeRedistributable in the license and Hydra would evaluate it - but that appears to have been removed. If you had your own Hydra instance you could still do something like that with this in your config:

let lib = import <nixpkgs/lib>;

in {
  allowUnfree = false;
  whitelistedLicenses = [ lib.licenses.unfreeRedistributable ];
}

Or make up some other license for it.

CMCDragonkai · 2018-12-10T03:23:25Z

Awesome, I mentioned this a while ago. But if you want to do this on an older Nixpkgs hash this is what I did:

# 7.0.5
wget 'https://developer.download.nvidia.com/compute/redist/cudnn/v7.0.5/cudnn-9.0-linux-x64-v7.tgz'
wget 'https://developer.download.nvidia.com/compute/redist/cudnn/v7.0.5/cudnn-9.1-linux-x64-v7.tgz'
# 7.1.4
wget 'https://developer.download.nvidia.com/compute/redist/cudnn/v7.1.4/cudnn-9.2-linux-x64-v7.1.tgz'

# then use nix-store or nix-prefetch-url to load them to the /nix/store
nix-store --add-fixed sha256 ./cudnn-9.0-linux-x64-v7.tgz
nix-prefetch-url file:://$(pwd)/cudnn-9.0-linux-x64-v7.tgz

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Nov 12, 2017

grahamc reviewed Nov 15, 2017

View reviewed changes

lukeadams force-pushed the cudnn_links branch from ec72fd0 to a9d3e3c Compare November 16, 2017 19:36

lukeadams force-pushed the cudnn_links branch from a9d3e3c to 157d34a Compare November 16, 2017 19:59

lukeadams force-pushed the cudnn_links branch from 157d34a to 4991963 Compare December 18, 2017 03:12

GrahamcOfBorg added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 labels Dec 18, 2017

lukeadams force-pushed the cudnn_links branch from 4991963 to 79855ae Compare January 20, 2018 06:12

orivej reviewed Jan 20, 2018

View reviewed changes

lukeadams force-pushed the cudnn_links branch from 79855ae to 4a91d13 Compare January 20, 2018 23:31

lukeadams force-pushed the cudnn_links branch from 4a91d13 to 41e5be3 Compare February 11, 2018 04:35

lukeadams force-pushed the cudnn_links branch from 41e5be3 to 8252753 Compare March 1, 2018 23:14

lukeadams force-pushed the cudnn_links branch 2 times, most recently from d008f93 to 01d433d Compare March 15, 2018 03:07

lukeadams force-pushed the cudnn_links branch from 01d433d to 737013b Compare March 25, 2018 02:48

lukeadams force-pushed the cudnn_links branch from 737013b to e50a99a Compare May 14, 2018 01:44

lukeadams force-pushed the cudnn_links branch from e50a99a to 61e22cc Compare June 27, 2018 00:38

jb55 approved these changes Jun 27, 2018

View reviewed changes

cudnn*_cudatoolkit*: use NVIDIA mirror instead of requireFile

a0ce9bb

cudnn_cudatoolkit7: update hash since public mirror is different

ac049e9

lukeadams force-pushed the cudnn_links branch from 61e22cc to ac049e9 Compare July 17, 2018 19:03

matthewbauer approved these changes Jul 17, 2018

View reviewed changes

orivej-nixos merged commit eba8679 into NixOS:master Jul 18, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cudnn_cudatoolkit: use public NVIDIA mirror #31551

cudnn_cudatoolkit: use public NVIDIA mirror #31551

lukeadams commented Nov 12, 2017 •

edited

grahamc commented Nov 12, 2017

lukeadams commented Nov 12, 2017 •

edited

grahamc Nov 12, 2017

lukeadams Nov 15, 2017 •

edited

lukeadams commented Nov 16, 2017 •

edited

lukeadams commented Jan 20, 2018

orivej Jan 20, 2018

lukeadams Jan 20, 2018

orivej Jan 20, 2018

lukeadams commented Jan 20, 2018

lukeadams commented Feb 11, 2018

lukeadams commented Mar 1, 2018

lukeadams commented Mar 15, 2018

lukeadams commented May 14, 2018

lukeadams commented Jun 27, 2018 •

edited

jb55 left a comment

lukeadams commented Jul 17, 2018 •

edited

matthewbauer commented Jul 17, 2018 •

edited

lukeadams commented Jul 18, 2018

orivej commented Jul 18, 2018

lukeadams commented Jul 18, 2018

lukeadams commented Jul 19, 2018

matthewbauer commented Jul 19, 2018 •

edited

CMCDragonkai commented Dec 10, 2018

cudnn*_cudatoolkit*: use public NVIDIA mirror #31551

cudnn*_cudatoolkit*: use public NVIDIA mirror #31551

Conversation

lukeadams commented Nov 12, 2017 • edited

Motivation for this change

grahamc commented Nov 12, 2017

lukeadams commented Nov 12, 2017 • edited

grahamc Nov 12, 2017

Choose a reason for hiding this comment

lukeadams Nov 15, 2017 • edited

Choose a reason for hiding this comment

lukeadams commented Nov 16, 2017 • edited

lukeadams commented Jan 20, 2018

orivej Jan 20, 2018

Choose a reason for hiding this comment

lukeadams Jan 20, 2018

Choose a reason for hiding this comment

orivej Jan 20, 2018

Choose a reason for hiding this comment

lukeadams commented Jan 20, 2018

lukeadams commented Feb 11, 2018

lukeadams commented Mar 1, 2018

lukeadams commented Mar 15, 2018

lukeadams commented May 14, 2018

lukeadams commented Jun 27, 2018 • edited

jb55 left a comment

Choose a reason for hiding this comment

lukeadams commented Jul 17, 2018 • edited

matthewbauer commented Jul 17, 2018 • edited

lukeadams commented Jul 18, 2018

orivej commented Jul 18, 2018

lukeadams commented Jul 18, 2018

lukeadams commented Jul 19, 2018

matthewbauer commented Jul 19, 2018 • edited

CMCDragonkai commented Dec 10, 2018

cudnn_cudatoolkit: use public NVIDIA mirror #31551

cudnn_cudatoolkit: use public NVIDIA mirror #31551

lukeadams commented Nov 12, 2017 •

edited

lukeadams commented Nov 12, 2017 •

edited

lukeadams Nov 15, 2017 •

edited

lukeadams commented Nov 16, 2017 •

edited

lukeadams commented Jun 27, 2018 •

edited

lukeadams commented Jul 17, 2018 •

edited

matthewbauer commented Jul 17, 2018 •

edited

matthewbauer commented Jul 19, 2018 •

edited