Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bootstrap tools test: fixup after d71833e
- Loading branch information
Showing
2 changed files
with
7 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6655ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this seems like an issue in fetchipfs.... Is there a way we can get fetchipfs to just give us a tarball like fetchurl? I hate to have to put .srcTarball everywhere now when people want to switch to ipfs. Maybe we should rollback hello to just use fetchurl?
Anyway this also needs to be done in darwin: see #31577
f6655ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot Darwin. IPFS can store any file, but (I think) it was decided to store an uncompressed one, probably to benefit from deduplication on updates. Well,
hello
is a demo so nothing really matters there.Anyway, as shown on tests around https://github.com/NixIPFS, IPFS isn't really suitable yet for distributing large amounts of data (e.g. what our binary cache does). Unfortunately.
f6655ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, reverted now.