Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lftp: 4.8.2 -> 4.8.3 #31542

Merged
merged 1 commit into from Nov 12, 2017
Merged

lftp: 4.8.2 -> 4.8.3 #31542

merged 1 commit into from Nov 12, 2017

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Nov 11, 2017

Motivation for this change

Version bump

2017-10-09: lftp-4.8.3 released. Coredumps on exit were fixed.

@bjornfor @sigma for review

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

$ ./result/bin/lftp --version
LFTP | Version 4.8.3 | Copyright (c) 1996-2017 Alexander V. Lukyanov

@grahamc
Copy link
Member

grahamc commented Nov 12, 2017

@GrahamcOfBorg build lftp

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-linux

error: attribute ‘build’ in selection path ‘build’ not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/bin/lftp
gzipping man pages under /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/share/man/
stripping (with flags -S) in /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/lib  /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/bin 
patching script interpreter paths in /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3
/nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/share/lftp/import-netscape: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
/nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/share/lftp/xdg-move: interpreter directive changed from "/bin/bash" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/bash"
/nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/share/lftp/import-ncftp: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
/nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3/bin/lftpget: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-lftp-4.8.3.drv-0 in /nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3...
/nix/store/0f6zcq71k0mbd7lnlf9h3aawhjw0airm-lftp-4.8.3

@disassembler disassembler merged commit 65424ea into NixOS:master Nov 12, 2017
@disassembler
Copy link
Member

looks good! merging!

@c0bw3b
Copy link
Contributor Author

c0bw3b commented Nov 12, 2017

EDIT: disregarding previous comment (bot)

@c0bw3b c0bw3b deleted the pkg/lftp branch November 12, 2017 09:43
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: attribute 'build' in selection path 'build' not found

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

these paths will be fetched (0.83 MiB download, 3.69 MiB unpacked):
  /nix/store/9hzbs7vv27nx4nyzfn0n307p7s07jacs-lftp-4.8.3
  /nix/store/i9j2p81ig1cz5nvardgbvgpf1qq53hpw-libidn2-2.0.4
fetching path '/nix/store/i9j2p81ig1cz5nvardgbvgpf1qq53hpw-libidn2-2.0.4'...
copying path '/nix/store/i9j2p81ig1cz5nvardgbvgpf1qq53hpw-libidn2-2.0.4'...
fetching path '/nix/store/9hzbs7vv27nx4nyzfn0n307p7s07jacs-lftp-4.8.3'...
copying path '/nix/store/9hzbs7vv27nx4nyzfn0n307p7s07jacs-lftp-4.8.3'...
/nix/store/9hzbs7vv27nx4nyzfn0n307p7s07jacs-lftp-4.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants