Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

braincurses: init at 1.1.0 #31562

Merged
merged 1 commit into from Nov 12, 2017
Merged

braincurses: init at 1.1.0 #31562

merged 1 commit into from Nov 12, 2017

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b c0bw3b self-assigned this Nov 12, 2017
lukateras
lukateras approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to play it, but it works. All good, ready to merge!

pkgs/games/braincurses/default.nix Outdated

# There is no install target in the Makefile
installPhase = ''
install -D braincurses $out/bin/braincurses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be even shorter :-)

install -Dt $out/bin braincurses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint! I've shortened it.

c0bw3b
c0bw3b approved these changes Nov 12, 2017
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@orivej orivej merged commit 5e69810 into NixOS:master Nov 12, 2017
@dotlambda
Copy link
Member Author

dotlambda commented Nov 13, 2017 •
edited

@GrahamcOfBorg build braincurses
(I just wanna know if it builds on Darwin too)

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 13, 2017

It won't because of platforms.linux

@grahamc
Copy link
Member

grahamc commented Nov 13, 2017

@GrahamcOfBorg build braincurses

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 13, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux


100  427k  100  427k    0     0   427k      0  0:00:01 --:--:--  0:00:01 1388k

fetching path ‘/nix/store/ii0mqp0gl2vhdvnq1zvsnrabvf9ld20d-braincurses-1.1.0’...

*** Downloading ‘https://cache.nixos.org/nar/0pwbfvkqkg4krn2616587v0pg7k2y1h3dg0x2iyj0i3l7swdf4l2.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/ii0mqp0gl2vhdvnq1zvsnrabvf9ld20d-braincurses-1.1.0’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 15340  100 15340    0     0  15340      0  0:00:01 --:--:--  0:00:01  109k

/nix/store/ii0mqp0gl2vhdvnq1zvsnrabvf9ld20d-braincurses-1.1.0

@lukateras
Copy link
Member

lukateras commented Nov 13, 2017 •
edited

@dotlambda Try to build it with nix-build -E "with import <nixpkgs> {}; callPackage ./. { stdenv = clangStdenv; }". If it does, there's a good chance it will build on Darwin.

@dotlambda
Copy link
Member Author

@yegortimoshenko It does. Do you think I should set platforms to unix? Also, do you know of any easy way to test on macOS without Apple hardware?

GrahamcOfBorg
GrahamcOfBorg reviewed Nov 13, 2017
View reviewed changes
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

error: Package ‘braincurses-1.1.0’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31562/pkgs/games/braincurses/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@dotlambda dotlambda deleted the braincurses branch December 13, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamcOfBorg GrahamcOfBorg GrahamcOfBorg left review comments

@lukateras lukateras lukateras approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees

@c0bw3b c0bw3b

Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dotlambda @c0bw3b @grahamc @lukateras @GrahamcOfBorg @orivej