enlightenment: 0.21.10 -> 0.22.0 #31532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg enlightenment |
There was a problem hiding this comment.
Failure for system: x86_64-linux
error: getting status of ‘/home/grahamc/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31532/pkgs/desktops/enlightenment/enlightenment.suid-exes.patch’: No such file or directory
(use ‘--show-trace’ to show detailed location information)
There was a problem hiding this comment.
Failure for system: x86_64-darwin
error: Package ‘econnman-1.1’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/31532/pkgs/desktops/enlightenment/econnman.nix:24 is not supported on ‘x86_64-darwin’, refusing to evaluate.
a) For `nixos-rebuild` you can set
{ nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.
b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
{ allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
grahamc
reviewed
Nov 11, 2017
| # enlightenment programs, the file $out/e-wrappers.nix is created, | ||
| # containing the needed configuration for that purpose. It can be | ||
| # used in the enlightenment module. | ||
| patches = [ ./enlightenment.suid-exes.patch ]; |
There was a problem hiding this comment.
Looks like this patch wasn't added.
There was a problem hiding this comment.
In fact I have forgot to add the patch.
|
@GrahamcOfBorg build enlightenment |
GrahamcOfBorg
approved these changes
Nov 12, 2017
There was a problem hiding this comment.
Success for system: x86_64-linux
stripping (with flags -S) in /nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0/lib /nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0/bin
patching script interpreter paths in /nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0
/nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0/bin/enlightenment_remote: interpreter directive changed from "/bin/sh" to "/nix/store/4ada72n7785wwazv42fhsnxjvilaa3aj-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-enlightenment-0.22.0.drv-0 in /nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0...
/nix/store/k71xrbdx754c6885x7wyjj67wvwhh1ck-econnman-1.1
/nix/store/xblgndx58yhg2yq15qwylpfa1fis2zg5-efl-1.20.5
/nix/store/26103099wy4xhc69yy9bg56i82qaddhx-enlightenment-0.22.0
/nix/store/nxaggb7jpsglqih16ymwhpbpm3fqblys-ephoto-1.5
/nix/store/r79iwk5cy4lyh5pcy2wc6r98ri2wf488-rage-0.2.1
/nix/store/sm8c42f3ydjjn8bah8x5k4f52v5y6lnl-terminology-1.1.1
disassembler
suggested changes
Nov 12, 2017
|
@disassembler Squash of the commits into a single commit done. |
c0bw3b
reviewed
Nov 12, 2017
| ln -sv $CPUFREQ_DIRPATH/e_freqset $out/bin/e_freqset | ||
| ln -sv /run/wrappers/bin/e_freqset $CPUFREQ_DIRPATH/freqset | ||
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "The Compositing Window Manager and Desktop Shell"; | ||
| homepage = http://enlightenment.org/; |
There was a problem hiding this comment.
This is a permanent redirect to https://www.enlightenment.org/ (nitpick)
|
I think it should be https instead of http. |
- Update to version 0.22.0 - Switch build tools from autotools to meson - Change handling of setuid programs
Fixed |
|
merged! great work! thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)