Format: insert space between { and % to prevent writing {%
#5278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed crystal-lang#5277 I think it is the best solution because it treats same thing against `{{` already.
|
This is so ugly but I think its the only solution. |
RX14
approved these changes
Nov 12, 2017
| end | ||
|
|
||
| # This is to prevent writing `{%` | ||
| if @token.raw.starts_with?("%") |
There was a problem hiding this comment.
Why not make this a joint if condition to avoid duplication?
There was a problem hiding this comment.
btw, argument passed to starts_with? call here could be a Char instead of String.
Thank you @straight-shoota and @Sija
RX14
approved these changes
Nov 13, 2017
|
Hello @mverzilli and @bcardiff, can we get your approval on this PR? Thank you. |
mverzilli
approved these changes
Nov 24, 2017
makenowjust
deleted the
fix/crystal-format/5277-insert-space-between-brace-and-percent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5277
I think it is the best solution because it treats same thing against
{{already.